Fix installation of default conf files.#885
Open
LocutusOfBorg wants to merge 1 commit into
Open
Conversation
CMAKE_INSTALL_SYSCONFDIR points to /etc, and this is where the location of configuration files has to be found.
Otherwise, it becomes /usr/etc, and with configuration files installed elsewhere (/etc), there is a mismatch between where the code tries to find the file, and where the file is actually located, e.g.
INSTALL(FILES dlt-system.conf
DESTINATION ${CONFIGURATION_FILES_DIR}
COMPONENT base)
This makes the conf file not being correctly evaluated on startup, because the systemd service script doesn't pass any value for "-c" switch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMAKE_INSTALL_SYSCONFDIR points to /etc, and this is where the location of configuration files has to be found.
Otherwise, it becomes /usr/etc, and with configuration files installed elsewhere (/etc), there is a mismatch between where the code tries to find the file, and where the file is actually located, e.g.
INSTALL(FILES dlt-system.conf
DESTINATION ${CONFIGURATION_FILES_DIR}
COMPONENT base)
This makes the conf file not being correctly evaluated on startup, because the systemd service script doesn't pass any value for "-c" switch