[PD1-138] Standardize Continuous Integration workflow - #32
Merged
Conversation
## Why The Dependabot review-and-merge automation we run in `ui` reacts to CI through a `workflow_run` trigger, and `workflow_run` matches a workflow by its **display name**, not its filename. Rolling that automation out across the fleet therefore needs one agreed name in every Python and JavaScript repository. The standard, now documented in the `defining-github-workflows` skill in `meta-software`, is: - the workflow lives at `.github/workflows/ci.yml` and is named `CI`; - it triggers on `pull_request`, and on `push` restricted to the default branch, so a feature branch does not run CI twice and the automation can rely on the pull request run; - any `paths:` filter includes the dependency manifest and lock file, so a dependency-only pull request still runs CI; - it never skips `dependabot[bot]`, since a skipped run means no automated review. ## What changed - Renamed the workflow from `Continuous Integration` to `CI`. - Limited `push` runs to `main`; pull request runs already cover feature branches. No job, step, or matrix entry changed, so the checks that run are the same ones as before. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Dependabot review-and-merge automation we run in
uireacts to CI through aworkflow_runtrigger, andworkflow_runmatches a workflow by its display name, not its filename. Rolling that automation out across the fleet therefore needs one agreed name in every Python and JavaScript repository. The standard, now documented in thedefining-github-workflowsskill inmeta-software, is:.github/workflows/ci.ymland is namedCI;pull_request, and onpushrestricted to the default branch, so a feature branch does not run CI twice and the automation can rely on the pull request run;paths:filter includes the dependency manifest and lock file, so a dependency-only pull request still runs CI;dependabot[bot], since a skipped run means no automated review.What changed
Continuous IntegrationtoCI.pushruns tomain; pull request runs already cover feature branches.No job, step, or matrix entry changed, so the checks that run are the same ones as before.