Conversation
Contributor
|
Thank you for the pull request, @Guillar1! ✅ We can confirm we have a CLA on file for you. |
Guillar1
marked this pull request as ready for review
July 17, 2026 17:24
Contributor
|
@Guillar1 Would you mind listing out any config setup we need to do for this PR? Thanks! |
Contributor
|
Took an initial pass and this looks good. Still working on getting access to test the dev setup. And understood we are waiting on more setup and OKs for prod down the line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds Amplitude analytics to Sandcastle.
Analytics only run when
VITE_AMPLITUDE_API_KEYis set at build time. Builds without a key send no data, so local development and forks are unaffected by default. Session start/end are captured automatically by Amplitude; everything else is an explicittrackEventcall.The catalog lives in three places that describe the same set: the
AnalyticsEventNametype insrc/analytics/amplitude.ts,src/analytics/tracking-plan.csv(Amplitude CSV import format), andsrc/analytics/README.md.Events
demo_iddemo_id,labels,method(browse/search/url)term,result_countdemo_idsource(nav_button/console_action)source(nav_button/close_button)provider(anthropic/gemini/vertex)model,provider,message_lengthPlus
[Amplitude] Start Sessionand[Amplitude] End Session, which Amplitude generates on its own and are not part of the tracking plan CSV.No credential values, code contents, or message text are recorded.
Gallery Searchedrecords the search term, andCopilot Message Sentrecords only the message's character count.Requests before this can merge
I need help from someone with the right access:
packages/sandcastle/src/analytics/tracking-plan.csvinto both the prod and dev projects so the events show up with descriptions and typed properties.PROD_AMPLITUDE_API_KEY: the new prod project key, used by.github/workflows/prod.ymlfor the sandcastle.cesium.com build.DEV_AMPLITUDE_API_KEY: the dev project key, used by.github/workflows/sandcastle-dev.ymlfor the dev-sandcastle.cesium.com build.Until the secrets exist the workflows still build and deploy fine, the key just resolves to an empty string and no analytics are sent.
Issue number and link
Testing plan
packages/sandcastle/.env.exampletopackages/sandcastle/.env.localand setVITE_AMPLITUDE_API_KEYto that key.packages/sandcastle/src/analytics/tracking-plan.csvinto the project.Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my changeAI acknowledgment
If yes, I used the following Tools(s) and/or Service(s):
If yes, I used the following Model(s):