ci: re-land release workflow & version handling (lost from main)#6
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Restores a previously-lost GitHub Actions release pipeline by reintroducing tag-based version resolution, packaging of published outputs into archives, and a release job that creates a GitHub Release (plus provenance attestation). It also removes the stale hardcoded MSBuild <Version> so versions are consistently sourced from the tag in CI.
Changes:
- Remove hardcoded
<Version>fromDirectory.Build.propsso CI-driven versioning from tags is authoritative. - Rework
.github/workflows/release.ymlto (a) resolve version from tag with a guard, (b) publish + package per-RID artifacts, and (c) create/publish a GitHub Release with checksums and build-provenance attestation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
Directory.Build.props |
Removes stale hardcoded version to rely on tag-injected versioning in CI. |
.github/workflows/release.yml |
Restores/modernizes the release workflow: version resolution, per-RID packaging, release creation, checksum generation, and provenance attestation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #4 ("Update release workflow and improve version handling") is marked merged on GitHub, but its changes are not present in
mainand never shipped — the merge commit was dropped whenmainwas subsequently force-pushed/rebased. As a result, thev0.2.6release ran the oldrelease.yml:@v4actions → Node 20 deprecation warningsThis PR cherry-picks the original work (
6652f8cfromci/release-assets-immutable) back onto currentmain. Cherry-pick applied cleanly with no conflicts.What this restores
checkout@v6,setup-dotnet@v5,upload-artifact@v7,download-artifact@v8,attest-build-provenance@v2(clears the Node 20 deprecation warnings)-p:Version=intodotnet publishanddotnet pack, with a command-injection guard on the tag name.tar.gz(Unix) /.zip(Windows) withif-no-files-found: errorreleasejob that creates the GitHub Release and produces a build-provenance attestation (id-token/attestationspermissions)<Version>0.2.3</Version>fromDirectory.Build.props(now sourced from the tag everywhere, including the NuGet pack job)Verification
release.ymlvalidates as well-formed YAMLmain(4cf2b70)-p:Version="$VERSION"from the resolved tag, so removing the hardcoded version is safeRecommend re-cutting a tag after merge so a release actually ships with this pipeline.