Skip to content

Replace navbar menu button text with hamburger icon on mobile #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seanh1995 wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −1
Open

Replace navbar menu button text with hamburger icon on mobile #301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/layouts/BaseLayout.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ const structuredData = JSON.stringify({
<header class="site-header">
<nav class="nav container" aria-label="Primary navigation">
<a class="nav-logo" href="/" aria-label="Chris Titus Tech home"><img src="/images/navlogo.webp" width="248" height="50" alt="Chris Titus Tech" /></a>
<button class="menu-button icon-button" type="button" data-menu-toggle aria-expanded="false" aria-controls="primary-links">Menu</button>
<button class="menu-button icon-button" type="button" data-menu-toggle aria-expanded="false" aria-controls="primary-links"><span class="menu-icon" aria-hidden="true"></span><span class="sr-only">Menu</span></button>
<div class="nav-links" id="primary-links" data-menu>
<a href="/posts/">Articles</a><a href="/downloads/">Downloads</a><a href="https://forum.christitus.com/">Forums</a><a href="/live-streams/">Live</a><a href="/newsletter/">Newsletter</a><a href="/categories/">Topics</a><a href="/search/">Search</a>
<button class="icon-button" type="button" data-theme-toggle aria-label="Switch to light theme"><span aria-hidden="true" data-theme-icon>☀</span><span class="sr-only">Change color theme</span></button>
Expand Down
8 changes: 8 additions & 0 deletions src/styles/global.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,14 @@ input {
display: none;
margin-left: auto;
}
.menu-icon::before {
content: "\2630";
font-size: 1.1em;
line-height: 1;
}
.menu-button[aria-expanded="true"] .menu-icon::before {
content: "\2715";
}
.icon-button,
.primary-button {
border: 1px solid var(--border);
Expand Down