Potential fix for code scanning alert no. 4337: Invalid string formatting#6
Draft
ChristianRosewich wants to merge 4 commits into
Draft
Potential fix for code scanning alert no. 4337: Invalid string formatting#6ChristianRosewich wants to merge 4 commits into
ChristianRosewich wants to merge 4 commits into
Conversation
…ting Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Console.Write(string.Format(CultureInfo.InvariantCulture, tmpl, lastObj)); | ||
| System.Diagnostics.Debug.Write(string.Format(CultureInfo.InvariantCulture, tmpl, lastObj)); | ||
| string output = tmpl.Contains("{0}", StringComparison.Ordinal) | ||
| ? string.Format(CultureInfo.InvariantCulture, tmpl, lastObj) |
Potential fix for code scanning alert no. 1: Complex condition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/ChristianRosewich/CSharp/security/code-scanning/4337
Use
string.Formatonly when the selected template actually contains a format item, and write the template directly otherwise.Best single fix in
CSharpBible/SomeThing/Statistic4/Program.cs(insideRun, in theif (fOut)block around lines 133–136):tmplretrieval.string.Format(..., tmpl, lastObj)calls with:tmpldirectly when no{0}placeholder is present.lastObjwhen{0}is present.outputstring for bothConsole.WriteandDebug.Write.This addresses all listed variants because templates without placeholders no longer receive an unused argument.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.