feat(helm): support extra volumes/mounts; add external API key mount-path validation#772
Open
JoeDerby wants to merge 11 commits intoCloudzero:developfrom
Open
feat(helm): support extra volumes/mounts; add external API key mount-path validation#772JoeDerby wants to merge 11 commits intoCloudzero:developfrom
JoeDerby wants to merge 11 commits intoCloudzero:developfrom
Conversation
Commented out the validation rules for apiKey and existingSecretName in the schema.
Removed anyOf and oneOf constraints for apiKey and existingSecretName.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
This PR adds first-class support for attaching custom extraVolumes and extraVolumeMounts to CloudZero workloads, while preserving safe API key configuration validation.
It enables external file-based credential flows (for example CSI-driven mounts) without introducing a new feature toggle, and keeps default chart behaviour intact for existing users.
What
Added new chart values:
Wired those values into all relevant workloads:
agent-deploy
agent-daemonset
aggregator-deploy
config-loader-job
webhook-deploy
backfill-job
Added reusable Helm helpers for extra volumes/mounts rendering.
Updated docs in helm/README.md and value schema definitions.
Strengthened schema validation:
Added render-time validation guard:
Added/updated Helm unit tests for:
Users need to mount additional volumes (including but not limited to CSI-backed sources) across CloudZero components without changing default secret behaviour.
At the same time, we need to avoid silent credential misconfigurations. This PR balances flexibility with clear guardrails.
Backward Compatibility
How Tested
All Helm unit tests suite passed.
Deployed from Fork to test agent is working.
Scenarios explicitly verified: