Skip to content

fix(sdk): handle cyclic run-state on session resume #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KazenDev wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −4
Open

fix(sdk): handle cyclic run-state on session resume #945

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions sdk/src/run-state.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,10 +790,19 @@ export async function applyOverridesToSessionState(
maxAgentSteps?: number
},
): Promise<SessionState> {
// Deep clone to avoid mutating the original session state
const sessionState = JSON.parse(
JSON.stringify(baseSessionState),
) as SessionState
// Deep clone to avoid mutating the original session state. A JSON
// round-trip is the fast path, but run state can carry cyclic values
// (e.g. recursive zod schemas inside tool blocks) that make
// JSON.stringify throw ("cannot serialize cyclic structures"); lodash
// cloneDeep handles cycles, so fall back to it. Mirrors cloneSessionState.
let sessionState: SessionState
try {
sessionState = JSON.parse(
JSON.stringify(baseSessionState),
) as SessionState
} catch {
sessionState = cloneDeep(baseSessionState)
}

// Apply maxAgentSteps override
if (overrides.maxAgentSteps !== undefined) {
Expand Down