[WIP] Fix NotFoundError when duplicating slider block#2834
Merged
Soare-Robert-Daniel merged 7 commits intoJun 16, 2026
Conversation
Co-authored-by: Soare-Robert-Daniel <17597852+Soare-Robert-Daniel@users.noreply.github.com>
Contributor
|
@codex[agent] also add an E2E tests by levreging the wp-env stat is already running |
Co-authored-by: Soare-Robert-Daniel <17597852+Soare-Robert-Daniel@users.noreply.github.com>
Author
Added Playwright E2E coverage for duplicating the Slider block (asserts no Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Contributor
Bundle Size Diff
|
Contributor
|
Plugin build for a021380 is ready 🛎️!
|
Contributor
E2E TestsPlaywright Test Status: See serial and parallel matrix jobs Performance ResultsserverResponse: {"q25":391,"q50":398.3,"q75":427,"cnt":10}, firstPaint: {"q25":493,"q50":533.9,"q75":646.8,"cnt":10}, domContentLoaded: {"q25":3259.4,"q50":3275.75,"q75":3323.4,"cnt":10}, loaded: {"q25":3261.5,"q50":3277.7,"q75":3325.6,"cnt":10}, firstContentfulPaint: {"q25":3767.3,"q50":3781.8,"q75":3852.1,"cnt":10}, firstBlock: {"q25":13417.7,"q50":13434.5,"q75":13547.9,"cnt":10}, type: {"q25":22.63,"q50":23.49,"q75":24.44,"cnt":10}, typeWithoutInspector: {"q25":20.06,"q50":20.68,"q75":32.37,"cnt":10}, typeWithTopToolbar: {"q25":29.14,"q50":29.89,"q75":36.41,"cnt":10}, typeContainer: {"q25":13.14,"q50":13.84,"q75":16.43,"cnt":10}, focus: {"q25":111.33,"q50":113.78,"q75":115.23,"cnt":10}, inserterOpen: {"q25":37.33,"q50":37.97,"q75":38.96,"cnt":10}, inserterSearch: {"q25":13.07,"q50":13.38,"q75":13.79,"cnt":10}, inserterHover: {"q25":4.87,"q50":4.99,"q75":5.35,"cnt":20}, loadPatterns: {"q25":1470.82,"q50":1526.03,"q75":1652.1,"cnt":10}, listViewOpen: {"q25":211.03,"q50":215.12,"q75":218.46,"cnt":10} |
Contributor
|
@codex[agent] rebase the current branch and check the e2e from wp-env |
Copilot stopped work on behalf of
Soare-Robert-Daniel due to an error
June 15, 2026 10:07
Control+Shift+D does not duplicate the slider in the WP 7.0 editor (the block opts out of the iframed canvas and captures key events), so the regression test stalled at one block and never exercised the duplicate -> unmount path it guards. Use the block toolbar Duplicate item instead. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
With block API v3 the editor canvas is iframed and Otter blocks render inside it, so query in-canvas elements through `editor.canvas`: - slider: the "duplicate does not throw NotFoundError" test queried the block via `page`; switch its document lookups to `editor.canvas` and drop the stale "opts out of the iframed canvas" comment. Also make the Form block suite resilient to cross-run option pollution: the form block appends to `themeisle_blocks_form_emails`, which over many runs accumulates entries that eventually fail REST schema validation and read back as null. Whitelist the form options in the e2e bootstrap and reset them to empty before each test via the otterUtils fixture. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.