Fix/onboarding final step checkbox spacing#2853
Open
harshitarora-in wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts the layout of the final step in the Otter onboarding/welcome guide modal to improve spacing around the email field and checkboxes and avoid an internal scrollbar.
Changes:
- Wraps the final welcome-guide page content in dedicated containers to better control spacing.
- Introduces new SCSS rules for the finish-step form field stack and checkbox alignment/margins.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/blocks/plugins/welcome-guide/index.js | Wrapes the finish-step content and adds a dedicated form-fields container + checkbox class for spacing control. |
| src/blocks/plugins/welcome-guide/editor.scss | Adds finish-step spacing styles (stack layout, gap, padding) and normalizes base-control margins for inputs/checkboxes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Bundle Size Diff
|
Contributor
|
Plugin build for e67c41c is ready 🛎️!
|
Contributor
E2E TestsPlaywright Test Status: See serial and parallel matrix jobs Performance ResultsserverResponse: {"q25":454.4,"q50":474.2,"q75":494.8,"cnt":10}, firstPaint: {"q25":534.6,"q50":597.85,"q75":631,"cnt":10}, domContentLoaded: {"q25":3355.8,"q50":3396.6,"q75":3416.6,"cnt":10}, loaded: {"q25":3356.3,"q50":3397.05,"q75":3417.1,"cnt":10}, firstContentfulPaint: {"q25":9107.1,"q50":9133.8,"q75":9175,"cnt":10}, firstBlock: {"q25":13671.4,"q50":13749.6,"q75":13813.1,"cnt":10}, type: {"q25":22.31,"q50":22.87,"q75":23.5,"cnt":10}, typeWithoutInspector: {"q25":17.14,"q50":17.86,"q75":19.13,"cnt":10}, typeWithTopToolbar: {"q25":27.07,"q50":27.92,"q75":29.35,"cnt":10}, typeContainer: {"q25":12.49,"q50":13.09,"q75":14.4,"cnt":10}, focus: {"q25":100.52,"q50":103.88,"q75":109.45,"cnt":10}, inserterOpen: {"q25":35.79,"q50":36.28,"q75":38.22,"cnt":10}, inserterSearch: {"q25":12.04,"q50":12.24,"q75":12.65,"cnt":10}, inserterHover: {"q25":4.71,"q50":5.03,"q75":5.29,"cnt":20}, loadPatterns: {"q25":1489.84,"q50":1518.1,"q75":1549.89,"cnt":10}, listViewOpen: {"q25":211.83,"q50":214.54,"q75":221.07,"cnt":10} |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Codeinwp/otter-internals/issues/302
Summary
Fixed spacing of the final onboarding step checkboxes.
Screenshots
Test instructions
Checklist before the final review