Skip to content

Fix/onboarding final step checkbox spacing#2853

Open
harshitarora-in wants to merge 3 commits into
developmentfrom
fix/onboarding-final-step-checkbox-spacing
Open

Fix/onboarding final step checkbox spacing#2853
harshitarora-in wants to merge 3 commits into
developmentfrom
fix/onboarding-final-step-checkbox-spacing

Conversation

@harshitarora-in

Copy link
Copy Markdown
Contributor

Closes https://github.com/Codeinwp/otter-internals/issues/302

Summary

Fixed spacing of the final onboarding step checkboxes.

Screenshots

Screenshot 2026-06-05 at 5 52 42 PM

Test instructions

  1. Open the Otter onboarding modal and go to the last step.
  2. Check spacing after email, between checkboxes, and before buttons.
  3. Confirm no internal scrollbar appears on that step.

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@harshitarora-in harshitarora-in requested a review from Copilot June 5, 2026 12:27
@pirate-bot pirate-bot added the pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) label Jun 5, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the layout of the final step in the Otter onboarding/welcome guide modal to improve spacing around the email field and checkboxes and avoid an internal scrollbar.

Changes:

  • Wraps the final welcome-guide page content in dedicated containers to better control spacing.
  • Introduces new SCSS rules for the finish-step form field stack and checkbox alignment/margins.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/blocks/plugins/welcome-guide/index.js Wrapes the finish-step content and adds a dedicated form-fields container + checkbox class for spacing control.
src/blocks/plugins/welcome-guide/editor.scss Adds finish-step spacing styles (stack layout, gap, padding) and normalizes base-control margins for inputs/checkboxes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/blocks/plugins/welcome-guide/index.js Outdated
@pirate-bot

pirate-bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Diff

Package Old Size New Size Diff
Animations 178.24 KB 178.24 KB 0 B (0.00%)
Blocks 1.47 MB 1.47 MB 2.03 KB (0.13%)
CSS 7.87 KB 7.87 KB 0 B (0.00%)
Dashboard 108.48 KB 108.48 KB 0 B (0.00%)
Onboarding 68.14 KB 68.14 KB 0 B (0.00%)
Export Import 4.7 KB 4.7 KB 0 B (0.00%)
Pro 299.31 KB 299.31 KB 0 B (0.00%)

@pirate-bot

pirate-bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Plugin build for e67c41c is ready 🛎️!

@pirate-bot

pirate-bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

E2E Tests

Playwright Test Status: See serial and parallel matrix jobs

Performance Results serverResponse: {"q25":454.4,"q50":474.2,"q75":494.8,"cnt":10}, firstPaint: {"q25":534.6,"q50":597.85,"q75":631,"cnt":10}, domContentLoaded: {"q25":3355.8,"q50":3396.6,"q75":3416.6,"cnt":10}, loaded: {"q25":3356.3,"q50":3397.05,"q75":3417.1,"cnt":10}, firstContentfulPaint: {"q25":9107.1,"q50":9133.8,"q75":9175,"cnt":10}, firstBlock: {"q25":13671.4,"q50":13749.6,"q75":13813.1,"cnt":10}, type: {"q25":22.31,"q50":22.87,"q75":23.5,"cnt":10}, typeWithoutInspector: {"q25":17.14,"q50":17.86,"q75":19.13,"cnt":10}, typeWithTopToolbar: {"q25":27.07,"q50":27.92,"q75":29.35,"cnt":10}, typeContainer: {"q25":12.49,"q50":13.09,"q75":14.4,"cnt":10}, focus: {"q25":100.52,"q50":103.88,"q75":109.45,"cnt":10}, inserterOpen: {"q25":35.79,"q50":36.28,"q75":38.22,"cnt":10}, inserterSearch: {"q25":12.04,"q50":12.24,"q75":12.65,"cnt":10}, inserterHover: {"q25":4.71,"q50":5.03,"q75":5.29,"cnt":20}, loadPatterns: {"q25":1489.84,"q50":1518.1,"q75":1549.89,"cnt":10}, listViewOpen: {"q25":211.83,"q50":214.54,"q75":221.07,"cnt":10}

@harshitarora-in harshitarora-in requested a review from abaicus June 9, 2026 18:29
@harshitarora-in harshitarora-in self-assigned this Jun 9, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants