Skip to content

fix: declare missing 'globals' devDependency (eslint 10 lint)#49

Merged
Coding-Dev-Tools merged 1 commit into
mainfrom
fix/eslint-add-globals-dep
Jul 3, 2026
Merged

fix: declare missing 'globals' devDependency (eslint 10 lint)#49
Coding-Dev-Tools merged 1 commit into
mainfrom
fix/eslint-add-globals-dep

Conversation

@Coding-Dev-Tools

Copy link
Copy Markdown
Owner

What

Adds globals to devDependencies (^17.7.0).

Why

eslint.config.mjs imports globals, but it was never declared — it came in transitively via eslint 9. After the eslint 10 upgrade (#47), that transitive path is gone, so npm install && eslint . failed with ERR_MODULE_NOT_FOUND: Cannot find package 'globals'. This restores green lint.

How to verify

npm install && npm run lint → exit 0 (verified locally under eslint 10.6.0).

…lint)

eslint.config.mjs imports 'globals' but it was only present transitively under
eslint 9. eslint 10 drops that transitive path, so 'npm install && eslint .'
failed with ERR_MODULE_NOT_FOUND. Declaring globals restores green lint.
@Coding-Dev-Tools Coding-Dev-Tools merged commit dac9c3c into main Jul 3, 2026
@Coding-Dev-Tools Coding-Dev-Tools deleted the fix/eslint-add-globals-dep branch July 3, 2026 23:56
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

🤖 Automated Code Review

✅ Ruff Lint — No issues

⚠️ Ruff Format — Formatting needed

Would reformat: src/api_contract_guardian/cli.py
Would reformat: src/api_contract_guardian/diff.py
Would reformat: src/api_contract_guardian/gate.py
Would reformat: src/api_contract_guardian/loader.py
Would reformat: src/api_contract_guardian/migration.py
Would reformat: tests/test_diff.py
Would reformat: tests/test_edge_cases.py
Would reformat: tests/test_gate.py
Would reformat: tests/test_migration.py
9 files would be reformatted, 6 files already formatted

✅ Secret Detection — Clean

✅ Large Files — Within limits

📊 Diff Stats — 2 file(s) changed

 package-lock.json | 16 +++++++++++++++-
 package.json      |  3 ++-
 2 files changed, 17 insertions(+), 2 deletions(-)

Verdict: ⚠️ Warnings — Lint/format issues found. Recommend fixing before merge.

Automated by Coding-Dev-Tools/.github reusable workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant