fix: fail CLA allowlist step on API errors - #20
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe CLA workflow now captures the GitHub API response for pull request commits. It logs an error and exits when the request fails. Successful responses continue through sorting, author exclusion, and allowlist generation. ChangesCLA workflow
Merge Risk: ⚪ Minimal · up to This localized workflow change makes CLA API failures fail explicitly while preserving valid author-only behavior; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Make the CLA author allowlist step fail when its GitHub API request fails instead of silently continuing with only the base allowlist.
Changes
Verification
The shared implementation was validated for author-only, co-author, and simulated API-failure scenarios in
Comfy-Org/comfy-cla.Propagates Comfy-Org/comfy-cla#1 and addresses Comfy-Org/ComfyUI_frontend#15555.