Skip to content

fix: fail CLA allowlist step on API errors - #20

Merged
alexisrolland merged 1 commit into
mainfrom
fix/cla-api-failure-handling
Aug 21, 2026
Merged

fix: fail CLA allowlist step on API errors#20
alexisrolland merged 1 commit into
mainfrom
fix/cla-api-failure-handling

Conversation

@alexisrolland

Copy link
Copy Markdown
Member

Summary

Make the CLA author allowlist step fail when its GitHub API request fails instead of silently continuing with only the base allowlist.

Changes

  • Capture the pull request commit API response before filtering authors.
  • Fail explicitly when the API request or pagination fails.
  • Preserve the valid author-only case where filtering produces no co-authors.

Verification

The shared implementation was validated for author-only, co-author, and simulated API-failure scenarios in Comfy-Org/comfy-cla.

Propagates Comfy-Org/comfy-cla#1 and addresses Comfy-Org/ComfyUI_frontend#15555.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 5fbe796e-b970-4eba-8d1a-ac1428c4087f

📥 Commits

Reviewing files that changed from the base of the PR and between 333b8bc and dd16fa9.

📒 Files selected for processing (1)
  • .github/workflows/cla.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The CLA workflow now captures the GitHub API response for pull request commits. It logs an error and exits when the request fails. Successful responses continue through sorting, author exclusion, and allowlist generation.

Changes

CLA workflow

Layer / File(s) Summary
Validate commit lookup
.github/workflows/cla.yml
The workflow stores the commit lookup output, reports API failures, and stops before allowlist generation. Successful results continue through sorting and author exclusion.

Merge Risk: ⚪ Minimal · up to dd16f

This localized workflow change makes CLA API failures fail explicitly while preserving valid author-only behavior; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/cla-api-failure-handling
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/cla-api-failure-handling

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@alexisrolland
alexisrolland merged commit 8ff4733 into main Aug 21, 2026
27 of 43 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant