Skip to content

Fixed build errors integrating upstream qemu configure fixes - #3

Open
valerino wants to merge 2 commits into
Comsecuris:masterfrom
valerino:master
Open

Fixed build errors integrating upstream qemu configure fixes#3
valerino wants to merge 2 commits into
Comsecuris:masterfrom
valerino:master

Conversation

@valerino

Copy link
Copy Markdown

tested on ubuntu 18.04

@steev

steev commented Jul 17, 2018

Copy link
Copy Markdown

I don't think turning off Werror is the way to go.

The usb error is fixed via qemu/qemu@121829c this commit.

host-libusb is fixed with qemu/qemu@9d8fa0d which deals with the libusb deprecation but allows people to build still with older versions of libusb.

And, the VTE issue can be done with this commit.
qemu/qemu@82a4f1a#diff-e0320540bef9fc439412c472e5324303

The VTE changes actually change more upstream but since luaqemu still seems to be based on qemu 2.9.50 while upstream is 2.12, these 3 patches are all that are needed. Ideally, moving to 2.12 is best, and keeping up with upstream. I've looked into it briefly but a lot of hunks for the luajit patch fail and I haven't got the time to go through them just yet (not a developer of luaqemu, just interested in using it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants