Fix column slicing behavior on recipes page - #406
Open
svbarker wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, long time user of the site, first time contributor! I noticed that on the recipes page, I was seeing a column ordering of 1-3-2 instead of 1-2-3, and it turned out the fix was simple so I thought I'd throw up a PR. The
splicemethod mutates the original array, so what was happening was:this.results.splice(0, split)- Remove and return the first third of the results array (column 1)this.results.splice(split, split + split)- Remove and return the back half of what remains of the results array (what should have been column 3)this.results.splice(-split)-this.resultsis nowsplititems long, so take remove and return all of the rest of it (what should have been column 2)I switched these to
slice, which shallow-copies instead of mutating the original array, which I think is what was intended in the first place.