chore: bump crosspad-core and crosspad-gui submodules - #2
Open
matixan wants to merge 2 commits into
Open
Conversation
crosspad-core: be168f7 → 38522eb (notify-downstream workflow + IHttpClient) crosspad-gui: d5e02e8 → a9a8d2d (notify-downstream workflow + markdown_view + virtual device + app orchestrator) Fixes CI build failure caused by missing markdown_view.h include. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Bumps the crosspad-core and crosspad-gui git submodules to newer commits to pick up upstream changes (e.g., notify-downstream workflow, IHttpClient, markdown_view, virtual device, app orchestrator).
Changes:
- Update
crosspad-coresubmodule pointerbe168f7→38522eb - Update
crosspad-guisubmodule pointerd5e02e8→a9a8d2d
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crosspad-core | Advances submodule commit to bring in upstream core changes (notify-downstream workflow + IHttpClient). |
| crosspad-gui | Advances submodule commit to bring in upstream GUI changes (notify-downstream workflow + markdown_view + virtual device + app orchestrator). |
Comments suppressed due to low confidence (1)
crosspad-gui:1
- The PR description claims it fixes a CI build failure by adding a missing
crosspad-gui/components/markdown_view.hinclude inInstructionsApp.cppandUpdateApp.cpp, but the diff in this PR only updates submodule SHAs. If those include fixes are intended to be part of this PR, they should appear as changes in this repo (or be called out as being fixed within the bumped submodule commit). Otherwise, please update the PR description to reflect that the fix comes solely from the submodule bump (and optionally link to the upstream commit/PR incrosspad-guithat contains the include fix).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Mar 24, 2026
This was referenced Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
be168f7→38522eb(notify-downstream workflow + IHttpClient)d5e02e8→a9a8d2d(notify-downstream workflow + markdown_view + virtual device + app orchestrator)Fixes
CI build failure caused by missing
crosspad-gui/components/markdown_view.hinclude inInstructionsApp.cppandUpdateApp.cpp.🤖 Generated with Claude Code