docs(ci): correct stale Sprint 7 CycloneDX comments in release.yml#461
Open
CryptoJones wants to merge 1 commit into
Open
docs(ci): correct stale Sprint 7 CycloneDX comments in release.yml#461CryptoJones wants to merge 1 commit into
CryptoJones wants to merge 1 commit into
Conversation
) The header comment said the standalone CycloneDX SBOM step "was removed in Sprint 7 and is queued for Sprint 8 re-implementation", and the sanity-gate comment said it replaces the sbomSanityCheck task removed with the cyclonedxBom revert in PR #220. Both predate the Sprint 8 re-add of the org.cyclonedx.bom plugin (3.2.4). Comment-only: clarifies that this workflow ships the in-zip upstream-generator SBOM, that the CycloneDX plugin is back but build-local (build/reports/sbom/) and not shipped here, and that the Python sanity gate is intentionally separate from the plugin's own sbomSanityCheck (they gate different files). Points at docs/release/SBOM.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #451.
The
release.ymlheader comment still said the standalone CycloneDX SBOM step "was removed in Sprint 7 and is queued for Sprint 8 re-implementation", and the sanity-gate step comment said it "replaces the sbomSanityCheck task that was removed with the cyclonedxBom revert in PR #220". Both predate the Sprint 8 re-add of theorg.cyclonedx.bomplugin at 3.2.4 (the same drift fixed in #460 / #445).Comment-only — no workflow logic changes. Clarifies:
build/reports/sbom/) and not shipped by this workflow.sbomSanityChecktask — they gate different files (the extracted in-zip SBOM vs. the build-local plugin SBOM).docs/release/SBOM.md.YAML validated with
yaml.safe_load.🤖 Generated with Claude Code