test(build): simplify generateRandomDebugPort()#462
Open
CryptoJones wants to merge 1 commit into
Open
Conversation
The old implementation drew a full 32-bit int, XOR-folded the high bytes down into the low 8 bits across a 4-iteration loop, then masked to 0xff — an obfuscated way to get a uniform 0..255. Replace it with ThreadLocalRandom.current().nextInt(256), which draws 0..255 uniformly in one call. Range is unchanged: 18300 + (0..255) = [18300, 18555], matching the original comment and well clear of the 1024..65535 bounds. Verified the range over 100k draws. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #454.
generateRandomDebugPort()drew a full 32-bitint, XOR-folded the high bytes down into the low 8 bits over a 4-iteration loop, then masked with0xff— a roundabout way to obtain a uniform0..255.Replaced with:
nextInt(256)draws0..255uniformly in one call (fully-qualified name avoids adding an import to the script). The port range is unchanged:18300 + (0..255)=[18300, 18555], matching the original comment and well clear of the1024..65535bounds.Verified the range holds over 100k draws.
🤖 Generated with Claude Code