Fix unreadable/overflowing panel text; scale-2 + bounded labels; v3.5.3#19
Merged
Merged
Conversation
The header, stereo meter, and spectrum panel drew labels at the small text scale (scale 1) in dim colors, which VLC's I420 chroma subsampling smears into an unreadable blur -- and a couple were positioned with a fixed x that overflowed their panel/window on long strings (the track title ran off the right edge; the CREST/CLIP readouts spilled past the STEREO panel border in the compact layout). Fixes (the readable tab labels already proved scale-2 renders cleanly): - Header title + status: scale-2, brighter, right-aligned to the window edge and truncated (new draw_text_right helper) so they can't overflow. - STEREO / METERS: reworked to an adaptive layout -- a fixed 156px readout column pinned to the right edge, L/R meters just left of it, vectorscope filling the rest. CORRELATION / CREST L/R / CLIP are scale-2 and bounded to the panel; the correlation marker is clamped inside its bar. - Spectrum: removed the redundant "FFT nnnn" label (the header already shows it). - Bumped the remaining small labels to scale-2 + brighter: waveform MID/SIDE/L/R, meter L/R, note cents/Hz readout, key-wheel center label, LUFS axis ticks. No scale-1 draw_text calls remain. Generalized dix_text_w(text, scale) and added a forward declaration. Bumps DIX_VERSION to 3.5.3. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JpVzsy8Wrc9DYEXns2Njzb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem (from CJ's screenshots)
The header,
STEREO / METERS, andSPECTRUMpanels drew labels at the small text scale in dim colors. VLC's I420 chroma subsampling smears thin, dim, colored text into an unreadable blur, and a couple of labels used a fixed x that overflowed their panel/window:44100HZ FFT 4096 LOGran to/off the right edge,CREST L/R/CLIPspilled past the STEREO panel border in the compact dashboard.The tab labels already proved scale-2 text renders crisply — so the fix is to use that size everywhere, brighten it, and bound it.
Fixes
draw_text_right()), so they can't overflow.CORRELATION / CREST L/R / CLIPare scale-2 and bounded to the panel; the correlation marker is clamped inside its bar.FFT nnnnlabel (the header shows it).MID/SIDE/L/R, meterL/R, note cents/Hz readout, key-wheel center label, LUFS axis ticks. No scale-1draw_textcalls remain.Generalized
dix_text_w(text, scale); bumpedDIX_VERSIONto 3.5.3. Builds clean; deployed + re-sealed for verification.🤖 Generated with Claude Code
Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/