ci: resolve downstream asset names by build OS in manifest#151
Merged
jh-lee-cryptolab merged 1 commit intoJun 2, 2026
Merged
Conversation
runed and rune-mcp now name their release assets by build OS (runed-<ver>-ubuntu-2204-amd64.tar.gz / runed-<ver>-mac-14-arm64.tar.gz, rune-mcp-ubuntu-2204-amd64, ...) instead of GOOS, to encode the glibc baseline — see CryptoLabInc/runed#9 and the matching rune-mcp change. The manifest generator hardcoded the old runed-<ver>-<goos>-<arch>.tar.gz and rune-mcp-<goos>-<arch> names, so it would build dead URLs and fail to read the sha256 entries. Resolve each platform's asset from the downloaded sha256 / checksums.txt files instead: map the manifest platform's GOOS to the os-type the downstream repos emit (linux -> ubuntu, darwin -> mac) and glob the exact OS version from the filenames, so a downstream runner bump needs no change here. The manifest platform keys (linux-amd64, darwin-arm64, ...) — the GOOS-GOARCH keys the rune CLI looks up at runtime — are unchanged.
esifea
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates the
release-rune-cli.ymlmanifest generator to consume the new build-OS-based asset names that runed and rune-mcp now publish:Why
The manifest step hardcoded
runed-${VERSION}-${goos}-${arch}.tar.gzandrune-mcp-${goos}-${arch}. After the downstream rename (CryptoLabInc/runed#9 and the matching rune-mcp PR, which encode the glibc baseline in the asset name), those reconstructed names no longer exist — the generator would emit dead download URLs and fail to read the.sha256/checksums.txtentries, breaking every tagged release.How
Instead of reconstructing names, each platform's asset is now discovered from the downloaded files:
linux -> ubuntu,darwin -> mac.2204,14, …) out of the downloaded*.tar.gz.sha256/checksums.txtfilenames, so a future downstream runner bump needs no change here.The manifest platform keys (
linux-amd64,darwin-arm64,linux-arm64) — theruntime.GOOS-runtime.GOARCHkeys the rune CLI looks up at install time (internal/bootstrap/paths.go) — are unchanged; only the URLs/checksums inside change.Notes
feat/go-migration(where the Go rune CLI + this workflow live).rune-<goos>-<arch>and its build runners are untouched — only the downstream-dependent manifest needed fixing._downstream/files with the new naming (all 3 platforms resolve to the correct asset + checksum). The release workflow only runs onv*tags, so it isn't exercised by this PR..release-pins.yaml) must be published with the new naming before tagging rune.