feat(bootstrap): add audit installation

[esifea]

TSIA

[jh-lee-cryptolab]

Refactor suggestion: return the resolved spec from ensure* instead of re-resolving in the audit block

The audit block re-calls m.LlamaServerForCurrentPlatform() / m.ModelSpec(variant). This carries two issues with a single shared root cause:

1. Latent nil panic (correctness) — install.go:98,135

llamaSpec, _ := m.LlamaServerForCurrentPlatform() // returns *LlamaServerSpec, nil on error
... llamaSpec.URL ...                              // panics if nil

Currently safe only because the audit block runs after ensureLlamaServer already succeeded on the same immutable manifest — an implicit ordering invariant that a future refactor can silently break. (ModelSpec is safe by contrast: it returns a value ArtifactSpec{}, so the two functions are asymmetric in risk.)

2. Redundant lookup — the spec resolved in the audit block is the exact value ensureLlamaServer/ensureModel already resolved moments earlier under the same lock.

Proposal

Have the internal helpers return the spec they already resolved, rather than looking it up a second time:

func ensureLlamaServer(...) (string, *LlamaServerSpec, error) { ... return target, spec, nil }
func ensureModel(...)       (string, ArtifactSpec, error)     { ... return target, spec, nil }

llamaBin, llamaSpec, err := ensureLlamaServer(...)
if err != nil { return ..., err }
modelPath, modelSpec, err := ensureModel(...)
if err != nil { return ..., err }

// audit block: the `llamaSpec, _ := ...` re-resolve line is gone entirely

Result

• feat(ci): add llama-server build and E2E smoke test gates #1 — llamaSpec is now a value that passed an err == nil check, so it can never be nil at the audit site. The _-discard pattern (and the panic risk) disappears.
• feat(ci): vendor llama-server build + GHCR-cached E2E smoke gate #2 — no second manifest lookup.
• The "audit only runs after a successful ensure" invariant is now enforced by the return type, not by call ordering.

Scope: ensureLlamaServer/ensureModel are unexported; the only callers are EnsureAll/EnsureLlamaServer/EnsureModel. No public API change.

[couragehong]

LGTM

[couragehong]

minor: tarball?

[esifea]

Fixed

[jh-lee-cryptolab]

LGTM