FAC-WEB feat: show faculty profile picture on evaluation and analytics screens#143
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
y4nder
added a commit
that referenced
this pull request
Apr 18, 2026
…s screens (#143) Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #142
Depends on API PR FAC-144 (ctrlaltelite-devs/api.faculytics) for the
faculty.profilePicturefield on the analytics report response.Summary
faculty-report-screen.tsx): renders anAvatarnext to the faculty name with initials fallback.evaluation-page-shell.tsxnow shows the faculty avatar beside the name.questionnaire-form-progress.tsx) shows a small avatar.facultyProfilePicturefrompage.tsx→EvaluationForm→EvaluationPageShell/QuestionnaireFormRenderer→QuestionnaireFormProgress.FacultyReportFacultyDto(frontend type) withprofilePicture?: string | null.Avatar/AvatarImage/AvatarFallback; smallgetInitialshelpers are colocated at each callsite (same pattern used infaculty-card.tsx).Test plan
bun run typecheckpassesbun run lintpasses/student/courses/<courseId>/evaluation— avatar appears in the "INSTRUCTOR" card and the sticky "EVALUATING" progress header; initials fallback whenprofilePictureis null/faculty/analyticsand dean/chairperson/(role)/faculties/<id>/analysis— avatar appears left of the faculty name; initials fallback when null