Skip to content

FAC-WEB feat: show faculty profile picture on evaluation and analytics screens#143

Merged
y4nder merged 1 commit into
developfrom
claude/add-faculty-profile-pictures-kb4kP
Apr 18, 2026
Merged

FAC-WEB feat: show faculty profile picture on evaluation and analytics screens#143
y4nder merged 1 commit into
developfrom
claude/add-faculty-profile-pictures-kb4kP

Conversation

@y4nder

@y4nder y4nder commented Apr 18, 2026

Copy link
Copy Markdown
Member

Closes #142

Depends on API PR FAC-144 (ctrlaltelite-devs/api.faculytics) for the faculty.profilePicture field on the analytics report response.

Summary

  • Analytics screen (faculty-report-screen.tsx): renders an Avatar next to the faculty name with initials fallback.
  • Student evaluation questionnaire:
    • "INSTRUCTOR" card in evaluation-page-shell.tsx now shows the faculty avatar beside the name.
    • Sticky "EVALUATING" progress header (questionnaire-form-progress.tsx) shows a small avatar.
  • Threaded facultyProfilePicture from page.tsxEvaluationFormEvaluationPageShell / QuestionnaireFormRendererQuestionnaireFormProgress.
  • Extended FacultyReportFacultyDto (frontend type) with profilePicture?: string | null.
  • Reuses the existing shadcn Avatar/AvatarImage/AvatarFallback; small getInitials helpers are colocated at each callsite (same pattern used in faculty-card.tsx).

Test plan

  • bun run typecheck passes
  • bun run lint passes
  • Manual: student opens /student/courses/<courseId>/evaluation — avatar appears in the "INSTRUCTOR" card and the sticky "EVALUATING" progress header; initials fallback when profilePicture is null
  • Manual: faculty self-view /faculty/analytics and dean/chairperson /(role)/faculties/<id>/analysis — avatar appears left of the faculty name; initials fallback when null

@vercel

vercel Bot commented Apr 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app-faculytics Ready Ready Preview, Comment Apr 18, 2026 6:29pm

@y4nder y4nder self-assigned this Apr 18, 2026
@y4nder y4nder merged commit 9fbdf02 into develop Apr 18, 2026
3 checks passed
y4nder added a commit that referenced this pull request Apr 18, 2026
…s screens (#143)

Co-authored-by: Claude <noreply@anthropic.com>
y4nder added a commit that referenced this pull request Apr 18, 2026
…s screens (#143) (#144)

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FAC-WEB feat: show faculty profile picture on evaluation and analytics screens

2 participants