FAC-WEB feat: faculty overall rating UI (pairs with FAC-145)#151
Merged
Conversation
Surfaces the faculty-level Overall Rating (50/25/25 weighted composite) above the report tabs via CompositeRatingSummaryStrip + info-popover breakdown. Relocates the per-type rating strip out of the screen header and into the Scores and Feedback tabs — directly under the questionnaire-type sub-tabs where the type is actually selected — so the two ratings are no longer stacked and redundant at the top. User-facing "Composite rating" renamed to "Overall rating" for readability; internal identifiers (COMPOSITE_TYPE_ORDER, CompositeCoverageStatus, file names, etc.) kept as-is. Always-rendered report shell keeps the sticky title and overall rating strip visible even while /report is loading or errored. Deleted unused faculty-analysis-hero.tsx (no consumers).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
y4nder
added a commit
that referenced
this pull request
Apr 23, 2026
…152) Surfaces the faculty-level Overall Rating (50/25/25 weighted composite) above the report tabs via CompositeRatingSummaryStrip + info-popover breakdown. Relocates the per-type rating strip out of the screen header and into the Scores and Feedback tabs — directly under the questionnaire-type sub-tabs where the type is actually selected — so the two ratings are no longer stacked and redundant at the top. User-facing "Composite rating" renamed to "Overall rating" for readability; internal identifiers (COMPOSITE_TYPE_ORDER, CompositeCoverageStatus, file names, etc.) kept as-is. Always-rendered report shell keeps the sticky title and overall rating strip visible even while /report is loading or errored. Deleted unused faculty-analysis-hero.tsx (no consumers).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CompositeRatingSummaryStripabove the Insights/Scores/Feedback tabs, consuming the newGET /api/v1/analytics/faculty/:facultyId/overviewendpoint (backend PR: FAC-145 feat: faculty composite overall rating (50/25/25) api.faculytics#381). Renders weighted rating + interpretation, amber coverage dot for non-FULLstates, and an info popover with per-track breakdown (weight / effective weight / contribution) and coverage banner per state.useFacultyOverviewhook (TanStack Query, 60s stale, enabled onfacultyId+semesterId).HeadlineMetricsStrip) out of the report header and into the Scores and Feedback tabs directly under the questionnaire-type sub-tabs, so the two ratings are no longer stacked and redundant at the top."Composite rating"→"Overall rating"in the strip, breakdown popover, and Export PDF tooltip. Internal identifiers (COMPOSITE_TYPE_ORDER,CompositeCoverageStatus, component/file names) kept as-is./reportis loading or errored (dual-failure shows"Faculty details unavailable").faculty-analysis-hero.tsx.Test plan
bun run typecheck— cleanbun run lint— cleanFULLcoverage → strip renders rating + interpretation, no amber dotPARTIAL→ amber dot, breakdown shows renormalised effective weightsPARTIAL_NO_FEEDBACK→"Insufficient data"copy, per-track ratings still shown with bannerNO_DATA→ strip collapses to empty-state copy; tabs hidden behind!hasAnalyticsDatabranch/reportNon-goals
FacultyAnalysisSentimentStripalready serves that role.Related