Tolerate UTF8 byte order marker in file parsing#831
Open
meekee7 wants to merge 1 commit into
Open
Conversation
Up to standards ✅🟢 Issues
|
Signed-off-by: Michael Kuerbis <michael_kuerbis@web.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UTF8-encoded text files may start with a UTF8 byte order marker (also abbreviated BOM) indicating that it is a UTF8 file. The byte sequence is
EF BB BF.This change ensures that files with a UTF8BOM can be read and parsed. The heuristic of
BomParserFactoryin particular would previously have rejected all files with a UTF8BOM.Test cases for both parsing and validation are added.
The test files were created by copying and saving them with UTF8BOM encoding in VS Code. The BOM character is not displayed in text previews on GitHub, but can be seen in a hex editor.