refactor(wallet): keep native DERO out of the contract-token list#20
Merged
Conversation
The token portfolio is for DERO-native contract assets. Native DERO is the base coin — its balance and send/receive live on the Dashboard — so it no longer appears as a row in the token list. Both token-list sources stop emitting the native entry: GetTrackedTokens no longer injects it, and GetTokenPortfolio (XSWD path) skips the zero SCID. TokenPortfolio.svelte drops the now-dead native handling (sort hoist, render branch, action-button gates) and shows a clearer empty state for wallets holding no contract tokens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The token portfolio now lists DERO-native contract assets only. Native
DERO — the base coin — no longer appears as a row in the token list; its
balance and send/receive live on the Dashboard.
Why
Listing native DERO alongside contract tokens made "send DERO" and "send
a token" the same gesture, and routed native sends through the
token-transfer path (reserved for non-zero SCIDs). Separating the base
coin from contract assets removes that ambiguity.
Changes
GetTrackedTokensno longer injects the native-DERO entry.GetTokenPortfolio(XSWD path) skips the zero SCID, for consistency.TokenPortfolio.sveltedrops the now-dead native handling — sorthoist, native render branch,
!token.nativeaction gates, native rowCSS — and shows a clearer empty state for wallets holding no contract
tokens.
Verification
go build ./...,go vet, andnpm run buildall pass.wails dev: the Tokens screen shows only contracttokens (no DERO row), row actions/balance render correctly, and the
Dashboard DERO balance is unaffected.