Improvement: Deactivate cmesh load and save for now#2279
Improvement: Deactivate cmesh load and save for now#2279
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2279 +/- ##
==========================================
+ Coverage 79.42% 82.59% +3.16%
==========================================
Files 115 115
Lines 19285 18545 -740
==========================================
Hits 15318 15318
+ Misses 3967 3227 -740 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -586,8 +615,16 @@ t8_cmesh_save (const t8_cmesh_t cmesh, const char *fileprefix) | |||
| t8_cmesh_t | |||
| t8_cmesh_load (const char *filename, sc_MPI_Comm comm) | |||
There was a problem hiding this comment.
In the remaining code, we prefer [[maybe_unused]], is there a reason why you decided to not use this?
There was a problem hiding this comment.
Yes, good point, I mixed something up here: Using [[maybe_unused]] in the source only, but not in the header (where we can't use it in this case, because it's a .h header) used to cause problems with the old doxygen version, but that is no longer an issue :-)
| @@ -432,7 +432,9 @@ t8_cmesh_commit (t8_cmesh_t cmesh, sc_MPI_Comm comm); | |||
| * \param[in] cmesh The cmesh to save. | |||
There was a problem hiding this comment.
The example IO/cmesh/t8_cmesh_load_save.cxx is relying on this function, maybe you can add a warning or even leave this out via cmake or also with #if 0? There are also other examples in IO that maybe should get a comment at least
| @@ -49,6 +49,7 @@ | |||
| return 0; \ | |||
| } | |||
|
|
|||
| #if 0 // Beginning of deactivated code section. | |||
There was a problem hiding this comment.
I am not a very big fan of the #if 0 and would prefer to somehow deactivate whole files via cmake but i understand the idea of printing error messages so maybe this is the way to go here. The functionality is well documented.
Closes #2265.
Describe your changes here:
We decided not to add a test to cmesh saving and loading, because they are heavily outdated anyway. Instead, we deactivate the code for now and throw an error message if it is called.
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
scripts/internal/find_all_source_files.shto check the indentation of these files.License
doc/(or already has one).