Fix blog chooser dialog styling on DNN 10 - #230
Open
Forro-54 wants to merge 1 commit into
Open
Conversation
Apply the required DNN popup classes directly to the generated blog chooser dialog, scope button styling to the current dialog, and keep the blog selector within its available width. Tested successfully on DNN 9.13.1 and DNN 10.3.2, including a production DNN 10.3.2 site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the malformed blog-selection dialog that appears when a user clicks New Post! and more than one blog is configured.
The chooser content was generated correctly, including the blog selector and action buttons, but under DNN 10 the required DNN popup classes were not reliably applied to the generated jQuery UI dialog wrapper. This caused the chooser controls to appear as unstyled page content instead of inside a properly formed popup.
Changes
This pull request updates:
Server/Blog/Controls/ManagementPanel.ascx
The repair:
obtains the generated jQuery UI dialog widget directly when the chooser opens;
applies dnnFormPopup, dnnClear, and dnnBlogChoosePopup directly to the generated dialog wrapper;
retains the existing dialogClass setting for compatibility;
scopes button-pane styling to the current blog chooser dialog instead of searching globally across the page;
preserves the existing primary and secondary action button styling;
sets the blog selector to width: 100% with box-sizing: border-box;
prevents the selector’s right edge and drop-down arrow from being clipped;
leaves the existing blog-selection and post-navigation logic unchanged.
Before
When multiple blogs were configured and New Post! was selected:
the blog chooser title appeared outside a popup;
the blog selector appeared as unstyled page content;
the New Post and Cancel buttons were not contained within a properly styled dialog;
the selector’s drop-down arrow could be partially clipped.
After
The blog chooser now:
forms as a properly styled DNN popup;
appears centred on the screen;
contains the title, selector, and action buttons correctly;
displays the full blog selector and drop-down arrow;
allows the user to select the intended blog;
closes correctly when Cancel is selected;
proceeds to the correct post editor when New Post is selected.
Testing
The repair was tested successfully on:
DNN Platform 9.13.1 development site;
DNN Platform 10.3.2 development site;
DNN Platform 10.3.2 production site.
The following scenarios were verified:
opening the chooser when multiple blogs are configured;
selecting between available blogs;
creating a new post for the selected blog;
cancelling and closing the chooser;
correct popup positioning and styling;
full visibility of the selector and its drop-down arrow.
No server-side code, blog permissions, blog data, or navigation logic was changed.
Please mark which issue is solved
Close #229