In integration tests, store drunc console output in a log file and check for warnings and errors#162
Open
bieryAtFnal wants to merge 6 commits into
Open
In integration tests, store drunc console output in a log file and check for warnings and errors#162bieryAtFnal wants to merge 6 commits into
bieryAtFnal wants to merge 6 commits into
Conversation
added 6 commits
July 15, 2026 10:20
…nsole output to a log file.
…cking to log_file_checks.py
…ed pattern that matched a given logfile name was being checked instead of all patterns that matched the logfile name.
…e X11 forwarding setup failed for all app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, in our integration test infrastructure, the
druncconsole output...However, there is no checking of this console output when determining whether the integtest passed or failed. The main goal of these changes is to add this checking.
My sense is that it would be great if we could use the same mechanism to allow some messages in the
druncconsole output to be ignored and others to be required when determining success or failure of the integtest, just like we do with messages in DAQ application log files. This led me to consider simply storing thedruncconsole output in a log file and doing the log-file-checking on it along with checking the existing log files. I can imagine that there might be other benefits of having thedruncconsole output in a log file (e.g. later reference), so I went ahead with that idea.The changes in this PR...
druncconsole in a log file (in the same location on disk as all of the other integtest log files)druncconsole output that have the word "error" in them but do not actually indicate an errorHere are sample instructions for testing these changes:
Type of change
Testing checklist
dunedaq_integtest_bundle.sh)Further checks