Homework - #17
Open
MrSnoki wants to merge 4 commits into
Open
Conversation
| #include "utils.hpp" | ||
|
|
||
| #include "iostream" | ||
| #include <stack> |
There was a problem hiding this comment.
- Хидеры стандартной библиотеки включаются с использованием угловых скобок
- Одноимённый хидер (в данном случае это
utils.hpp) следует отделять от остальных хидеров пустой строкой
#include "utils.hpp"
#include <iostream>
#include <stack>
| case ('+'): | ||
| result = a + b; | ||
| return result; | ||
| break; |
There was a problem hiding this comment.
После return break не нужен (недостижимый код). Я бы убрал
| size_t start; | ||
| size_t end = 0; | ||
| int flag = 0; | ||
| int begin = 0; |
There was a problem hiding this comment.
- Тип переменной "flag" должен быть
bool, а переменной "begin"size_t - Имена можно было сделать более говорящими, иначе сложно понять, что код делает. Мой вариант:
size_t word_start;
size_t word_end = 0;
bool in_brackets = false;
size_t opening_bracket = 0;
- Соблюдайте отступы
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Студент Сальный Валерий группа М03-213С