Skip to content

homework - #10

Open
byllet wants to merge 25 commits into
DafeMipt213:mainfrom
byllet:main
Open

homework#10
byllet wants to merge 25 commits into
DafeMipt213:mainfrom
byllet:main

Conversation

@byllet

@byllet byllet commented Dec 26, 2023

Copy link
Copy Markdown

No description provided.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 55. Check the log or trigger a new build to see more.


const long long INF = std::numeric_limits<long long>::max();

long long BussesInVasyuki(std::vector<std::vector<Edge>>& g, size_t from,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: unknown type name 'size_t'; did you mean 'std::size_t'? [clang-diagnostic-error]

Suggested change
long long BussesInVasyuki(std::vector<std::vector<Edge>>& g, size_t from,
long long BussesInVasyuki(std::vector<std::vector<Edge>>& g, std::size_t from,
Additional context

/usr/include/x86_64-linux-gnu/c++/12/bits/c++config.h:297: 'std::size_t' declared here

  typedef __SIZE_TYPE__ 	size_t;
                         ^

const long long INF = std::numeric_limits<long long>::max();

long long BussesInVasyuki(std::vector<std::vector<Edge>>& g, size_t from,
size_t to) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: unknown type name 'size_t'; did you mean 'std::size_t'? [clang-diagnostic-error]

Suggested change
size_t to) {
std::size_t to) {
Additional context

/usr/include/x86_64-linux-gnu/c++/12/bits/c++config.h:297: 'std::size_t' declared here

  typedef __SIZE_TYPE__ 	size_t;
                         ^

size_t to) {
std::vector<long long> departure_time(g.size(), INF);
departure_time[from] = 0;
std::set<std::pair<long long, size_t>> q;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: use of undeclared identifier 'size_t'; did you mean 'sizeof'? [clang-diagnostic-error]

Suggested change
std::set<std::pair<long long, size_t>> q;
std::set<std::pair<long long, sizeof>> q;

size_t to) {
std::vector<long long> departure_time(g.size(), INF);
departure_time[from] = 0;
std::set<std::pair<long long, size_t>> q;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: expected expression [clang-diagnostic-error]

  std::set<std::pair<long long, size_t>> q;
                                      ^

std::set<std::pair<long long, size_t>> q;
q.insert(std::make_pair(0, from));
while (!q.empty()) {
std::pair<size_t, unsigned long long> cur = *q.begin();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: unknown type name 'size_t'; did you mean 'std::size_t'? [clang-diagnostic-error]

Suggested change
std::pair<size_t, unsigned long long> cur = *q.begin();
std::pair<std::size_t, unsigned long long> cur = *q.begin();
Additional context

/usr/include/x86_64-linux-gnu/c++/12/bits/c++config.h:297: 'std::size_t' declared here

  typedef __SIZE_TYPE__ 	size_t;
                         ^

@@ -0,0 +1,6 @@
#pragma once

#include <graph.hpp>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'graph.hpp' file not found [clang-diagnostic-error]

#include <graph.hpp>
         ^


class FindCutVertexesFunction : public TinUpFunction {
public:
FindCutVertexesFunction(size_t n) : TinUpFunction(n) {}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: constructor does not initialize these fields: cut_vertexes_ [cppcoreguidelines-pro-type-member-init]

task_02/src/cut_vertex_finder.cpp:29:

-   std::vector<size_t> cut_vertexes_;
+   std::vector<size_t> cut_vertexes_{};

@@ -0,0 +1,6 @@
#pragma once

#include <graph.hpp>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'graph.hpp' file not found [clang-diagnostic-error]

#include <graph.hpp>
         ^

Comment thread task_02/src/test.cpp
@@ -1,6 +1,155 @@

#include <gtest/gtest.h>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'gtest/gtest.h' file not found [clang-diagnostic-error]

#include <gtest/gtest.h>
         ^

@@ -0,0 +1,23 @@
#pragma once

#include <abstract_function.hpp>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'abstract_function.hpp' file not found [clang-diagnostic-error]

#include <abstract_function.hpp>
         ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant