Skip to content

(Auras) Fix claimed Boss/Priority/Role debuffs leaking into the debuff row #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Enf0 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

(Auras) Fix claimed Boss/Priority/Role debuffs leaking into the debuff row #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

### Bug Fixes

* (Auras) Fix a claimed Boss/Priority/Role debuff still rendering a second time in the debuff row's Crowd Control, Raid, Dispellable or Non-Player group whenever it also matched one of those categories. "Hide Duplicate Debuffs" only ever subtracted a category from the row's own Boss/Role/Priority record; a category an Aura Designer debuff group claimed outright had no such record to subtract from, so the other category records never learned to exclude it.

### Changes

## [5.3.0]
Expand Down
17 changes: 13 additions & 4 deletions DandersFrames/Features/Auras.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,12 +357,21 @@ local function BuildDirectDebuffFilters(db, claimed)
candidateFilters = cfFor(true, extra),
style = importantStyle }
end
-- Subtract whichever important records were declared. Returns a FRESH table each
-- call because cfFor mutates and returns the table it is handed.
-- Subtract whichever important records were declared, AND whichever
-- categories an Aura Designer group has claimed — a claimed category has
-- no row record of its own to read back, so leaving it out here let a
-- claimed Boss/Priority debuff double-render through CC/Raid/Dispellable/
-- Non-Player. Fresh table each call: cfFor mutates and returns what it's
-- handed.
local excludeBoss = boss or (claimed and claimed.boss) or false
local excludeRole = role or (claimed and claimed.role) or false
local excludePriority = db.debuffFilterPriority or (claimed and claimed.priority) or false
local function notImportant(extra)
extra = extra or {}
if importantFlag then extra[importantFlag] = false end
if priorityDeclared then extra.isPriorityAura = false end
if excludeBoss and excludeRole then extra.isBossOrRoleAura = false
elseif excludeBoss then extra.isBossAura = false
elseif excludeRole then extra.isRoleAura = false end
if excludePriority then extra.isPriorityAura = false end
return extra
end
if ccToken and not (claimed and claimed.crowdControl) then
Expand Down