Skip to content

Main wagmi#574

Closed
Dargon789 wants to merge 157 commits into
mainfrom
main-wagmi
Closed

Main wagmi#574
Dargon789 wants to merge 157 commits into
mainfrom
main-wagmi

Conversation

@Dargon789
Copy link
Copy Markdown
Owner

@Dargon789 Dargon789 commented May 20, 2026

Summary by Sourcery

Enhancements:

  • Replace string-based execSync usage with argument-based spawnSync when invoking forge clean in the Foundry plugin.

dependabot Bot and others added 30 commits March 30, 2024 07:24
Bumps the npm_and_yarn group with 1 update in the / directory: [express](https://github.com/expressjs/express).


Updates `express` from 4.18.2 to 4.19.2
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.18.2...4.19.2)

---
updated-dependencies:
- dependency-name: express
  dependency-type: direct:development
  dependency-group: npm_and_yarn-security-group
...

Signed-off-by: dependabot[bot] <support@github.com>
…yarn-security-group-e0cd778f82

Bump the npm_and_yarn group across 1 directory with 1 update
Snyk has created this PR to upgrade @tanstack/react-query from 5.45.1 to 5.64.2.

See this package in npm:
@tanstack/react-query

See this project in Snyk:
https://app.snyk.io/org/dargon789/project/bb845543-cbee-4e11-8cf9-8bfdf9205bf1?utm_source=github&utm_medium=referral&page=upgrade-pr
…9e16dcb9a2eda9

Snyk upgrade 03178c54d4c54014129e16dcb9a2eda9
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
Bumps the npm_and_yarn group with 1 update in the / directory: [next](https://github.com/vercel/next.js).


Updates `next` from 15.4.2 to 15.4.7
- [Release notes](https://github.com/vercel/next.js/releases)
- [Changelog](https://github.com/vercel/next.js/blob/canary/release.js)
- [Commits](vercel/next.js@v15.4.2...v15.4.7)

---
updated-dependencies:
- dependency-name: next
  dependency-version: 15.4.7
  dependency-type: direct:production
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
Bumps the npm_and_yarn group with 1 update in the / directory: [happy-dom](https://github.com/capricorn86/happy-dom).
Bumps the npm_and_yarn group with 1 update in the /packages/wallet/dapp-client directory: [happy-dom](https://github.com/capricorn86/happy-dom).
Bumps the npm_and_yarn group with 1 update in the /packages/wallet/wdk directory: [happy-dom](https://github.com/capricorn86/happy-dom).


Updates `happy-dom` from 17.6.3 to 20.0.0
- [Release notes](https://github.com/capricorn86/happy-dom/releases)
- [Commits](capricorn86/happy-dom@v17.6.3...v20.0.0)

Updates `happy-dom` from 17.6.3 to 20.0.0
- [Release notes](https://github.com/capricorn86/happy-dom/releases)
- [Commits](capricorn86/happy-dom@v17.6.3...v20.0.0)

Updates `happy-dom` from 17.6.3 to 20.0.0
- [Release notes](https://github.com/capricorn86/happy-dom/releases)
- [Commits](capricorn86/happy-dom@v17.6.3...v20.0.0)

---
updated-dependencies:
- dependency-name: happy-dom
  dependency-version: 20.0.0
  dependency-type: direct:development
  dependency-group: npm_and_yarn
- dependency-name: happy-dom
  dependency-version: 20.0.0
  dependency-type: direct:development
  dependency-group: npm_and_yarn
- dependency-name: happy-dom
  dependency-version: 20.0.0
  dependency-type: direct:development
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps the npm_and_yarn group with 1 update in the / directory: [happy-dom](https://github.com/capricorn86/happy-dom).


Updates `happy-dom` from 20.0.0 to 20.0.2
- [Release notes](https://github.com/capricorn86/happy-dom/releases)
- [Commits](capricorn86/happy-dom@v20.0.0...v20.0.2)

---
updated-dependencies:
- dependency-name: happy-dom
  dependency-version: 20.0.2
  dependency-type: direct:development
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Dargon789 and others added 16 commits December 23, 2025 18:15
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
* 2.3.7 (#131)

* fix broken guard private key

* Expose access to passkey credential list

* Dapp client direct txn request (0xsequence#856)

* Signature request refactor

* WIP

* Refactor

* Update dapp-client exports (0xsequence#858)

* Add hasPermission method to DappClient (0xsequence#859)

* Save discovered passkey credentials upon login

* Expose name property in PasskeySignupArgs

* Fix blacklist sort

* Add multi server script

* relayer: /SimulateV3 (0xsequence#857)

* Add await for handleOpenDB scheduleExpiration

* Update increment to always include native once used

* Fix session tests

* Adding lastLoginAt to PasskeyCredential

* LoginToPasskeyArgs now accept a credentialId which is used to specify which credential to use

* Adding onSignatureRequestStatus function to register single use callbacks for when a request reaches a terminal state of completed or cancelled

* When a login is cancelled we can remove the wallet which is logging-in

* Add RC3 contracts

* Sessions space restriction

* Dedupe signers for encoding

* Support RC3 sessions

* Tightly increment call validation

* CLI defaults to RC3 wallet code

* Rc3 address test

* Fix hashing tests

* Add deprecated encoding test

* wdk: throw errors from otp respond callback (0xsequence#864)

* wdk: throw errors from otp respond callback

* wdk: otp auth error and handler refactor

* Handle guard 2FA (0xsequence#861)

* guard: return a specific error when auth required

* core: pass guard token to the service

* wdk: handle prompting for guard 2FA code

* dapp-client: handle prompting for guard 2FA code

* guard 2fa tests

* wdk: separate wallet and sessions guards

* dapp-client: remove guard 2fa

* dapp-client: fix imports

* fix guard tests

* wdk: remove unneeded promise resolve

* Update relayer and api gen.ts, force public packages

* Add standalone fetch queued payloads

* Replacing GuardRole enum with string union type, as well as replacing guardAddresses Map with Record<GuardRole, Address>

* Fallback to chain for non-logged in recovery

* Add Katana, Sandbox Tesnet, Incentiv Testnet v2 (0xsequence#873)

* Update a few remaining dev1 contract addresses to rc3 (0xsequence#874)

* Remove unnecessary console.error where we already throw error

* Improve DappClient hasPermission method

* Wallet db try checksum and lowercase

* Update dapp client json utils to include Map reviver and replacer

* Bump next in the npm_and_yarn group across 1 directory

Bumps the npm_and_yarn group with 1 update in the / directory: [next](https://github.com/vercel/next.js).


Updates `next` from 15.4.2 to 15.4.7
- [Release notes](https://github.com/vercel/next.js/releases)
- [Changelog](https://github.com/vercel/next.js/blob/canary/release.js)
- [Commits](vercel/next.js@v15.4.2...v15.4.7)

---
updated-dependencies:
- dependency-name: next
  dependency-version: 15.4.7
  dependency-type: direct:production
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update type name, update exports for dapp client

* Expired explicit sessions can't sign

* Improve session validity test

* session isValid returns invalid reason

* InvalidReason is typed

* Support multiple identity signers in sessions configuration

* Device signers can approve implicit sessions

* Remove invalid test

* Fix recursion

* Fix comment

* Improve test stability by reducing race conditions

* Do not set passkey signer as identity signer

* Use length checks

* Throw on missing identity signer

* Encoding requires identity signer to encode

* Fix test

* Refactor/types namings tsdoc redundant code (0xsequence#880)

* refactor types, namings, ts doc

* fix session response payload

* change parameter name

* change parameter name

* change type in tests

* improve types and dapp client methods

* fix session test to use new types

* refactor

* refactor implicit sessions array in chain session manager

* remove unused types

* remove unused types and add ConnectionError

* update pnpm lock

* move reusable session types to wallet-core

* Update some imports and update some response type names

---------

Co-authored-by: Tolgahan Arikan <tolgahan.arikan@gmail.com>

* Fix check for explicit session for the updated type in dapp-client

* Update api.gen.ts and relayer.gen.ts

* Add missing chainId for dapp client event

* Fix initializing new chain session manager on redirect

* Add support for non-viem, custom Sequence chains (0xsequence#882)

* Update issue templates

* Provider sent to prepareBlankEnvelope

* Add session signature decoding

* Add feeTokens endpoint to relayer (0xsequence#885)

* const for node length

* Clearer blacklist size encoding

* identity signer node length

* Potential fix for code scanning alert no. 84: Insecure randomness

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>

* add getFeeTokens to dapp client (0xsequence#889)

* add getFeeTokens to dapp client

* fix typo

* make getFeeTokens independent of chain session manager and initialize state (0xsequence#890)

* make getFeeTokens independent of chain session manager and initialized state

* remove getFeeTokens from chain session manager

* Throw specific error when trying to sign with an expired session (0xsequence#887)

* Throw when supported session signer is expired

* Fix tests

* Make dapp-client implicit sessions chain agnostic (0xsequence#893)

* Add Monad, remove LAOS and Root Network

* Bump the npm_and_yarn group across 3 directories with 1 update

Bumps the npm_and_yarn group with 1 update in the / directory: [happy-dom](https://github.com/capricorn86/happy-dom).
Bumps the npm_and_yarn group with 1 update in the /packages/wallet/dapp-client directory: [happy-dom](https://github.com/capricorn86/happy-dom).
Bumps the npm_and_yarn group with 1 update in the /packages/wallet/wdk directory: [happy-dom](https://github.com/capricorn86/happy-dom).


Updates `happy-dom` from 17.6.3 to 20.0.0
- [Release notes](https://github.com/capricorn86/happy-dom/releases)
- [Commits](capricorn86/happy-dom@v17.6.3...v20.0.0)

Updates `happy-dom` from 17.6.3 to 20.0.0
- [Release notes](https://github.com/capricorn86/happy-dom/releases)
- [Commits](capricorn86/happy-dom@v17.6.3...v20.0.0)

Updates `happy-dom` from 17.6.3 to 20.0.0
- [Release notes](https://github.com/capricorn86/happy-dom/releases)
- [Commits](capricorn86/happy-dom@v17.6.3...v20.0.0)

---
updated-dependencies:
- dependency-name: happy-dom
  dependency-version: 20.0.0
  dependency-type: direct:development
  dependency-group: npm_and_yarn
- dependency-name: happy-dom
  dependency-version: 20.0.0
  dependency-type: direct:development
  dependency-group: npm_and_yarn
- dependency-name: happy-dom
  dependency-version: 20.0.0
  dependency-type: direct:development
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump happy-dom in the npm_and_yarn group across 1 directory (#69)

Bumps the npm_and_yarn group with 1 update in the / directory: [happy-dom](https://github.com/capricorn86/happy-dom).


Updates `happy-dom` from 20.0.0 to 20.0.2
- [Release notes](https://github.com/capricorn86/happy-dom/releases)
- [Commits](capricorn86/happy-dom@v20.0.0...v20.0.2)

---
updated-dependencies:
- dependency-name: happy-dom
  dependency-version: 20.0.2
  dependency-type: direct:development
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Create SECURITY.md for security policy (#70)

* Create SECURITY.md for security policy

Add a security policy document outlining supported versions and vulnerability reporting.

Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>

* Update SECURITY.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>

* Update SECURITY.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>

---------

Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update SECURITY.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>

* Add support for sessionless dapp connection (0xsequence#896)

* Refactor relayer package & update dependant packages  (0xsequence#891)

* refactor exports for relayer (0xsequence#900)

* Add Arc Testnet

* Fix changelog config

* Sessionless connection upgrade and error handling in DappClient (0xsequence#902)

* dapp-client: add sessionless snapshot restore flow

* Bump the npm_and_yarn group across 3 directories with 1 update

Bumps the npm_and_yarn group with 1 update in the / directory: [happy-dom](https://github.com/capricorn86/happy-dom).
Bumps the npm_and_yarn group with 1 update in the /packages/wallet/dapp-client directory: [happy-dom](https://github.com/capricorn86/happy-dom).
Bumps the npm_and_yarn group with 1 update in the /packages/wallet/wdk directory: [happy-dom](https://github.com/capricorn86/happy-dom).


Updates `happy-dom` from 17.6.3 to 20.0.2
- [Release notes](https://github.com/capricorn86/happy-dom/releases)
- [Commits](capricorn86/happy-dom@v17.6.3...v20.0.2)

Updates `happy-dom` from 17.6.3 to 20.0.2
- [Release notes](https://github.com/capricorn86/happy-dom/releases)
- [Commits](capricorn86/happy-dom@v17.6.3...v20.0.2)

Updates `happy-dom` from 17.6.3 to 20.0.2
- [Release notes](https://github.com/capricorn86/happy-dom/releases)
- [Commits](capricorn86/happy-dom@v17.6.3...v20.0.2)

---
updated-dependencies:
- dependency-name: happy-dom
  dependency-version: 20.0.2
  dependency-type: direct:development
  dependency-group: npm_and_yarn
- dependency-name: happy-dom
  dependency-version: 20.0.2
  dependency-type: direct:development
  dependency-group: npm_and_yarn
- dependency-name: happy-dom
  dependency-version: 20.0.2
  dependency-type: direct:development
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>

* Allow to logout a wallet with skipRemoveDevice even if the wallet is not in a ready state to allow force removing of wallets (0xsequence#906)

* Pass request to PromptCodeHandler in guard registerUI (0xsequence#909)

* Pass request to PromptCodeHandler in guard registerUI

* Fixing guard registerUI test

* guard: allow using recovery code as 2FA token (0xsequence#910)

* guard: allow using recovery code as 2FA token

* Cleanup types of ResponseFn

---------

Co-authored-by: Corban Riley <corbanbrook@gmail.com>

* Add a way to reset 2fa when using a backup code (0xsequence#911)

* Add a way to reset 2fa when using a backup code

* use the GuardToken type instead of breaking out the props

* Update SECURITY.md

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Update packages/wallet/dapp-client/src/DappTransport.ts

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Update package.json

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Update SECURITY.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Update wagmi-project/package.json

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Update wagmi-project/package.json

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Update wagmi-project/src/App.tsx

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Create FUNDING.json (#90)

Enhancements:
Include FUNDING.json to display GitHub sponsorship options in the repository
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Create config.yml (#91)

Add initial CircleCI configuration to enable automated builds using a custom Docker executor and a defined workflow.

Build:

Add .circleci/config.yml with version 2.1 specification and custom Docker executor.
CI:

Define web3-defi-game-project job with checkout step.
Set up my-custom-workflow to run the job.
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Add rc4 contracts

* Set rc4 as default and add it to lists

* Session enhanced replay protection

* New sessions replay protection hashes payload

* Use the 4337 factory wrapper

* Update keymachine url in dapp-client constants

* Update keymachine url in Provider constructor

* SSR safety (0xsequence#915)

* SSR safety test

* Fix CI job

* Guard dapp-client for SSR (lazy transport, browser checks, gated storage)

* Fix guard topology (0xsequence#918)

* Use proper guard topology

* Test and fixes

* login and setup tests

* Switch prod manager settings (0xsequence#917)

* Add prod guard and identity instrument info

* Remove completed TODOs

* Small JS tweaks (0xsequence#919)

* Fix type exports to built declarations

* Update repository links to current package paths

* Improve Next app tooling and React typings

* Expose primitives CLI bin and use base lint config

* Update relayer.gen.ts and TransactionPrecondition interface

* Update api.gen.ts

* Update metadata.gen.ts

* Update marketplace.gen.ts

* Update guard.gen.ts

* Support multiple identity signers in sessions configuration

* Device signers can approve implicit sessions

* Remove invalid test

* Fix recursion

* Fix comment

* Improve test stability by reducing race conditions

* Do not set passkey signer as identity signer

* Use length checks

* Throw on missing identity signer

* Encoding requires identity signer to encode

* Fix test

* Refactor/types namings tsdoc redundant code (0xsequence#880)

* refactor types, namings, ts doc

* fix session response payload

* change parameter name

* change parameter name

* change type in tests

* improve types and dapp client methods

* fix session test to use new types

* refactor

* refactor implicit sessions array in chain session manager

* remove unused types

* remove unused types and add ConnectionError

* update pnpm lock

* move reusable session types to wallet-core

* Update some imports and update some response type names

---------

Co-authored-by: Tolgahan Arikan <tolgahan.arikan@gmail.com>

* Fix check for explicit session for the updated type in dapp-client

* Update api.gen.ts and relayer.gen.ts

* Add missing chainId for dapp client event

* Fix initializing new chain session manager on redirect

* Add support for non-viem, custom Sequence chains (0xsequence#882)

* Provider sent to prepareBlankEnvelope

* Add session signature decoding

* const for node length

* Clearer blacklist size encoding

* identity signer node length

* Add feeTokens endpoint to relayer (0xsequence#885)

* add getFeeTokens to dapp client (0xsequence#889)

* add getFeeTokens to dapp client

* fix typo

* make getFeeTokens independent of chain session manager and initialize state (0xsequence#890)

* make getFeeTokens independent of chain session manager and initialized state

* remove getFeeTokens from chain session manager

* Throw specific error when trying to sign with an expired session (0xsequence#887)

* Throw when supported session signer is expired

* Fix tests

* Make dapp-client implicit sessions chain agnostic (0xsequence#893)

* Add Monad, remove LAOS and Root Network

* Add support for sessionless dapp connection (0xsequence#896)

* Refactor relayer package & update dependant packages  (0xsequence#891)

* refactor exports for relayer (0xsequence#900)

* Add Arc Testnet

* Fix changelog config

* Sessionless connection upgrade and error handling in DappClient (0xsequence#902)

* dapp-client: add sessionless snapshot restore flow

* Allow to logout a wallet with skipRemoveDevice even if the wallet is not in a ready state to allow force removing of wallets (0xsequence#906)

* Pass request to PromptCodeHandler in guard registerUI (0xsequence#909)

* Pass request to PromptCodeHandler in guard registerUI

* Fixing guard registerUI test

* guard: allow using recovery code as 2FA token (0xsequence#910)

* guard: allow using recovery code as 2FA token

* Cleanup types of ResponseFn

---------

Co-authored-by: Corban Riley <corbanbrook@gmail.com>

* Add a way to reset 2fa when using a backup code (0xsequence#911)

* Add a way to reset 2fa when using a backup code

* use the GuardToken type instead of breaking out the props

* Add rc4 contracts

* Set rc4 as default and add it to lists

* Session enhanced replay protection

* New sessions replay protection hashes payload

* Use the 4337 factory wrapper

* Update keymachine url in dapp-client constants

* Update keymachine url in Provider constructor

* SSR safety (0xsequence#915)

* Guard dapp-client for SSR (lazy transport, browser checks, gated storage)

* Fix guard topology (0xsequence#918)

* Use proper guard topology

* Test and fixes

* login and setup tests

* Switch prod manager settings (0xsequence#917)

* Add prod guard and identity instrument info

* Remove completed TODOs

* Small JS tweaks (0xsequence#919)

* Fix type exports to built declarations

* Update repository links to current package paths

* Improve Next app tooling and React typings

* Expose primitives CLI bin and use base lint config

* Update relayer.gen.ts and TransactionPrecondition interface

* Update relayer.gen.ts and TransactionPrecondition interface (0xsequence#920)

* 3.0.0-beta.1

* identity-instrument: generate nonce from current time (0xsequence#921)

* Remove publish-dists.yml github action (0xsequence#923)

* 3.0.0-beta.2

* Clean up changeset config

* Improve test stability by removing race conditions

* Ensure build before test

* Updating happy-dom to 20.0.10 (0xsequence#926)

* Add support for custom auth providers (authcode & authcode-pkce only) (0xsequence#894)

* Add support for custom auth providers (authcode & authcode-pkce only)

* fix authcode tests

* Updating Deps November 2025 (0xsequence#927)

* Updating deps for the workspace root

* Updating deps for wallet/wdk

* Fixing sessions test for latest vitest

* Lets not upgrade to the latest typescript quite yet

* Updating to latest vitest

* Updating deps for wallet/core

* Updating deps for wallet/primitives-cli

* Updating deps for wallet/dapp-client

* Adding syncpack to check for dep version inconsistencies

* Setup syncpack versionGroups for pnpm workspace:^

* Fixing dep versions mismatches

* Fixing @types/node mismatches

* Adding syncpack to pre commit hook

* Remove the syncpack format script.

* Update ox to v9.17.0 (0xsequence#928)

* Upgrading ox to 9.17.0

* WrappedSignature renamed to SignatureErc6492

* Fixing PasskeySignatureValidator interface

* Lock ox lib dep to use the same version with pnpm overrides and update viem to latest

* Fix explicitSessionRequested check in dapp client

* Typescript 5.9.3 (0xsequence#930)

* Upgrading to typescript v5.9.3

* Fix type errors that arose from typescript upgrade related to Bytes and Buffer source typings.

* Don't catch errors thrown by Guard 2FA or reject early to allow multiple attempts on incorrect TOTP (0xsequence#931)

* Update pnpm

* Mark @0xsequence/wallet-primitives-cli as private

* 3.0.0-beta.3

* changeset cleanup

* Fix rc4 4337 factory (0xsequence#933)

* Add rc5 and set it as default (0xsequence#934)

* 3.0.0-beta.4

* Update SECURITY.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Update wagmi-project/package.json

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Update wagmi-project/package.json

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Bump next from 15.5.5 to 15.5.7 (0xsequence#936)

Bumps [next](https://github.com/vercel/next.js) from 15.5.5 to 15.5.7.
- [Release notes](https://github.com/vercel/next.js/releases)
- [Changelog](https://github.com/vercel/next.js/blob/canary/release.js)
- [Commits](vercel/next.js@v15.5.5...v15.5.7)

---
updated-dependencies:
- dependency-name: next
  dependency-version: 15.5.7
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* add userdata service client (0xsequence#940)

* Skip LocalDevice identity signers not on current device (0xsequence#942)

* Skip LocalDevice identity signers not on current device

* Update log

* 3.0.0-beta.5

* Update config.yml (#102)

* Update config.yml

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Update .circleci/config.yml

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

---------

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

* Update config.yml (#103)

* Update config.yml

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Update .circleci/config.yml

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

---------

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

* fix: extras/web/package.json to reduce vulnerabilities (#101)

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-NEXT-14173355

Co-authored-by: snyk-io[bot] <141718529+snyk-io[bot]@users.noreply.github.com>

* fix: extras/docs/package.json to reduce vulnerabilities (#100)

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-NEXT-14173355

Co-authored-by: snyk-io[bot] <141718529+snyk-io[bot]@users.noreply.github.com>

* fix: package.json to reduce vulnerabilities (#104)

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-BABELHELPERS-9397697
- https://snyk.io/vuln/SNYK-JS-BABELRUNTIME-10044504
- https://snyk.io/vuln/SNYK-JS-BRACEEXPANSION-9789073
- https://snyk.io/vuln/SNYK-JS-CROSSSPAWN-8303230
- https://snyk.io/vuln/SNYK-JS-ELLIPTIC-7577916
- https://snyk.io/vuln/SNYK-JS-ELLIPTIC-7577917
- https://snyk.io/vuln/SNYK-JS-ELLIPTIC-7577918
- https://snyk.io/vuln/SNYK-JS-ELLIPTIC-8187303
- https://snyk.io/vuln/SNYK-JS-ELLIPTIC-8720086
- https://snyk.io/vuln/SNYK-JS-IMAGESIZE-9634164
- https://snyk.io/vuln/SNYK-JS-INFLIGHT-6095116
- https://snyk.io/vuln/SNYK-JS-JSYAML-13961110
- https://snyk.io/vuln/SNYK-JS-MICROMATCH-6838728
- https://snyk.io/vuln/SNYK-JS-NODEFORGE-14114940
- https://snyk.io/vuln/SNYK-JS-NODEFORGE-14125097
- https://snyk.io/vuln/SNYK-JS-NODEFORGE-14125745
- https://snyk.io/vuln/SNYK-JS-ONHEADERS-10773729
- https://snyk.io/vuln/SNYK-JS-ROLLUP-8073097
- https://snyk.io/vuln/SNYK-JS-SECP256K1-8237220
- https://snyk.io/vuln/SNYK-JS-SEND-7926862
- https://snyk.io/vuln/SNYK-JS-SERVESTATIC-7926865
- https://snyk.io/vuln/SNYK-JS-SHAJS-12089400

Co-authored-by: snyk-io[bot] <141718529+snyk-io[bot]@users.noreply.github.com>

* Revert "Merge remote-tracking branch 'origin/dependabot/npm_and_yarn/npm_and_yarn-318c02e2da'"

This reverts commit fd0fdf9, reversing
changes made to cba7894.

* fix: extras/web/package.json to reduce vulnerabilities (#109)

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-NEXT-14173355

Co-authored-by: snyk-bot <snyk-bot@snyk.io>

* fix: extras/docs/package.json to reduce vulnerabilities (#106)

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-NEXT-14400636
- https://snyk.io/vuln/SNYK-JS-NEXT-14400644

Co-authored-by: snyk-bot <snyk-bot@snyk.io>

* Bump next in the npm_and_yarn group across 1 directory (#110)

Bumps the npm_and_yarn group with 1 update in the / directory: [next](https://github.com/vercel/next.js).


Updates `next` from 15.5.7 to 15.5.9
- [Release notes](https://github.com/vercel/next.js/releases)
- [Changelog](https://github.com/vercel/next.js/blob/canary/release.js)
- [Commits](vercel/next.js@v15.5.7...v15.5.9)

---
updated-dependencies:
- dependency-name: next
  dependency-version: 15.5.9
  dependency-type: direct:production
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Delete .github/workflows/fortify.yml (#111)

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* fix: extras/web/package.json to reduce vulnerabilities (#107)

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-NEXT-14400636
- https://snyk.io/vuln/SNYK-JS-NEXT-14400644

Co-authored-by: snyk-bot <snyk-bot@snyk.io>

* Bump the npm_and_yarn group across 1 directory with 3 updates (#115)

Bumps the npm_and_yarn group with 1 update in the / directory: [next](https://github.com/vercel/next.js).


Updates `next` from 15.5.5 to 15.5.9
- [Release notes](https://github.com/vercel/next.js/releases)
- [Changelog](https://github.com/vercel/next.js/blob/canary/release.js)
- [Commits](vercel/next.js@v15.5.5...v15.5.9)

Updates `happy-dom` from 17.6.3 to 20.0.11
- [Release notes](https://github.com/capricorn86/happy-dom/releases)
- [Commits](capricorn86/happy-dom@v17.6.3...v20.0.11)

Updates `vite` from 7.1.10 to 7.2.7
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v7.2.7/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v7.2.7/packages/vite)

---
updated-dependencies:
- dependency-name: next
  dependency-version: 15.5.9
  dependency-type: direct:production
  dependency-group: npm_and_yarn
- dependency-name: happy-dom
  dependency-version: 20.0.11
  dependency-type: direct:development
  dependency-group: npm_and_yarn
- dependency-name: vite
  dependency-version: 7.2.7
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump next from 15.5.7 to 15.5.9 (0xsequence#944)

Bumps [next](https://github.com/vercel/next.js) from 15.5.7 to 15.5.9.
- [Release notes](https://github.com/vercel/next.js/releases)
- [Changelog](https://github.com/vercel/next.js/blob/canary/release.js)
- [Commits](vercel/next.js@v15.5.7...v15.5.9)

---
updated-dependencies:
- dependency-name: next
  dependency-version: 15.5.9
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Pin foundry to v1.5.0 instead of nightly (0xsequence#947)

* Include repo and extras in syncpack config to ensure deps are synced (0xsequence#945)

* Include repo and extras in syncpack config to ensure deps are synced across all

* Updating support deps

* Updating deps

* Updating pnpm lock

* Fixing type errors within wdk tests

* Short circuit 404s (0xsequence#949)

* skip witness on signers that don't support it

* add passkey to test

* 3.0.0-beta.6

* Update tests.yml (#119)

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Update config.yml (#120)

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Update packages/services/identity-instrument/src/index.ts

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* feat: upgrade @wagmi/cli from 0.1.15 to 2.8.0 (#126)

Snyk has created this PR to upgrade @wagmi/cli from 0.1.15 to 2.8.0.

See this package in npm:
@wagmi/cli

See this project in Snyk:
https://app.snyk.io/org/dargon789/project/bb845543-cbee-4e11-8cf9-8bfdf9205bf1?utm_source=github&utm_medium=referral&page=upgrade-pr

Co-authored-by: snyk-bot <snyk-bot@snyk.io>

* Potential fix for code scanning alert no. 82: Workflow does not contain permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Potential fix for code scanning alert no. 62: Information exposure through a stack trace

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: Patryk Kalinowski <patryk@kalinowski.dev>
Co-authored-by: Corban Riley <corbanbrook@gmail.com>
Co-authored-by: tolgahan-arikan <tolgahan.arikan@gmail.com>
Co-authored-by: Agusx1211 <agusgit@pm.me>
Co-authored-by: Michael Standen <screaminghawk@gmail.com>
Co-authored-by: William Hua <william@attente.ca>
Co-authored-by: Michael Standen <mstan@horizon.io>
Co-authored-by: Patryk Kalinowski <pkal@horizon.io>
Co-authored-by: Taylan Pince <taylanpince@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Gabi <56271768+VGabriel45@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Co-authored-by: snyk-io[bot] <141718529+snyk-io[bot]@users.noreply.github.com>
Co-authored-by: snyk-bot <snyk-bot@snyk.io>

* Update extras/docs/package.json

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Update extras/web/package.json

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: Patryk Kalinowski <patryk@kalinowski.dev>
Co-authored-by: Corban Riley <corbanbrook@gmail.com>
Co-authored-by: tolgahan-arikan <tolgahan.arikan@gmail.com>
Co-authored-by: Agusx1211 <agusgit@pm.me>
Co-authored-by: Michael Standen <screaminghawk@gmail.com>
Co-authored-by: William Hua <william@attente.ca>
Co-authored-by: Michael Standen <mstan@horizon.io>
Co-authored-by: Patryk Kalinowski <pkal@horizon.io>
Co-authored-by: Taylan Pince <taylanpince@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Gabi <56271768+VGabriel45@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Co-authored-by: snyk-io[bot] <141718529+snyk-io[bot]@users.noreply.github.com>
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
* Pin foundry to v1.5.0 instead of nightly (0xsequence#947) (#134)

* Bump next from 15.5.7 to 15.5.9 (0xsequence#944)

Bumps [next](https://github.com/vercel/next.js) from 15.5.7 to 15.5.9.
- [Release notes](https://github.com/vercel/next.js/releases)
- [Changelog](https://github.com/vercel/next.js/blob/canary/release.js)
- [Commits](vercel/next.js@v15.5.7...v15.5.9)

---
updated-dependencies:
- dependency-name: next
  dependency-version: 15.5.9
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Pin foundry to v1.5.0 instead of nightly (0xsequence#947)

* Include repo and extras in syncpack config to ensure deps are synced (0xsequence#945)

* Include repo and extras in syncpack config to ensure deps are synced across all

* Updating support deps

* Updating deps

* Updating pnpm lock

* Fixing type errors within wdk tests

* Short circuit 404s (0xsequence#949)

* skip witness on signers that don't support it

* add passkey to test

* 3.0.0-beta.6

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Taylan Pince <taylanpince@gmail.com>
Co-authored-by: Corban Riley <corbanbrook@gmail.com>
Co-authored-by: Agusx1211 <agusgit@pm.me>

* Update packages/wallet/wdk/test/wallets.test.ts

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Update packages/wallet/wdk/test/wallets.test.ts

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Taylan Pince <taylanpince@gmail.com>
Co-authored-by: Corban Riley <corbanbrook@gmail.com>
Co-authored-by: Agusx1211 <agusgit@pm.me>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Snyk has created this PR to upgrade react from 18.3.1 to 19.2.0.

See this package in npm:
react

See this project in Snyk:
https://app.snyk.io/org/dargon789/project/bb845543-cbee-4e11-8cf9-8bfdf9205bf1?utm_source=github&utm_medium=referral&page=upgrade-pr

Co-authored-by: snyk-bot <snyk-bot@snyk.io>
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-NEXT-14400636
- https://snyk.io/vuln/SNYK-JS-NEXT-14400644

Co-authored-by: snyk-io[bot] <141718529+snyk-io[bot]@users.noreply.github.com>
Co-authored-by: dargon789 <64915515+Dargon789@users.noreply.github.com>
Add initial monorepo structure for wagmi-project, including CLI, connectors, and core packages with source code, tests, configuration, and CI/CD workflows. This sets up the foundation for further development and collaboration.
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented May 20, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 20, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Replaces the use of execSync with spawnSync when running forge clean in the Foundry CLI plugin to adjust how the clean command is executed and its I/O handling.

Sequence diagram for Foundry plugin contracts clean execution

sequenceDiagram
  participant FoundryPlugin as foundry
  participant ContractsFn as contracts
  participant ChildProcess as child_process

  FoundryPlugin->>ContractsFn: contracts()
  alt clean is true
    ContractsFn->>ChildProcess: spawnSync(forgeExecutable, [clean, --root, project])
    ChildProcess-->>ContractsFn: { stdout, stderr, status }
  else clean is false
    ContractsFn-->>FoundryPlugin: return without running forge clean
  end
Loading

File-Level Changes

Change Details Files
Switch synchronous forge clean invocation from execSync to spawnSync in the Foundry CLI plugin.
  • Replace string-based execSync call with argument-array-based spawnSync call for the forge clean command
  • Preserve encoding and stdio options while changing the process invocation method
wagmi-project/packages/cli/src/plugins/foundry.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@vercel
Copy link
Copy Markdown

vercel Bot commented May 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sequence.js Ready Ready Preview, Comment May 20, 2026 2:09pm
wagmi-project Ready Ready Preview, Comment May 20, 2026 2:09pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
sequence-js-docs Skipped Skipped May 20, 2026 2:09pm
sequence-js-web Skipped Skipped May 20, 2026 2:09pm

@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented May 20, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue, and left some high level feedback:

  • With spawnSync, a non‑zero exit code from forge clean will no longer throw automatically as execSync did; consider checking status/error on the result and surfacing failures to maintain equivalent error behavior.
  • Since you are now using spawnSync, ensure the corresponding import is present and that any previous execSync import is removed to avoid dead code.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- With `spawnSync`, a non‑zero exit code from `forge clean` will no longer throw automatically as `execSync` did; consider checking `status`/`error` on the result and surfacing failures to maintain equivalent error behavior.
- Since you are now using `spawnSync`, ensure the corresponding import is present and that any previous `execSync` import is removed to avoid dead code.

## Individual Comments

### Comment 1
<location path="wagmi-project/packages/cli/src/plugins/foundry.ts" line_range="182-184" />
<code_context>
     async contracts() {
       if (clean)
-        execSync(`${forgeExecutable} clean --root ${project}`, {
+        spawnSync(forgeExecutable, ['clean', '--root', project], {
           encoding: 'utf-8',
           stdio: 'pipe',
         })
</code_context>
<issue_to_address>
**issue (bug_risk):** spawnSync return value / exit code is not checked, changing semantics vs execSync which throws on non-zero exit

With execSync, a non-zero exit from `forge clean` would throw, so failures were surfaced as exceptions. spawnSync instead returns a result object and will not throw on non-zero exit. Please check the returned `status` (and/or `error`) and propagate or handle failures to preserve the previous behavior and avoid silently ignoring `forge clean` errors.
</issue_to_address>

Fix all in Cursor


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread wagmi-project/packages/cli/src/plugins/foundry.ts
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the use of execSync with spawnSync for the forge clean command within the Foundry plugin. A review comment identifies a regression in error handling: unlike execSync, spawnSync does not throw an exception when a process exits with a non-zero status code. This could lead to silent failures where the build step proceeds despite a failed clean operation. It is recommended to explicitly check the status and error properties of the result.

Comment thread wagmi-project/packages/cli/src/plugins/foundry.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants