Codesandbox#600
Conversation
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
…quence.js into feature/integration
* Upgrade uuid from v13 to v14 (0xsequence#996) * Upgrading workspace root deps (0xsequence#997) * New userdata.gen.ts * 3.0.6 * 3.0.7 * Fix fee options for undeployed wallets (0xsequence#998) * Bump next from 15.5.14 to 15.5.15 (0xsequence#989) Bumps [next](https://github.com/vercel/next.js) from 15.5.14 to 15.5.15. - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](vercel/next.js@v15.5.14...v15.5.15) --- updated-dependencies: - dependency-name: next dependency-version: 15.5.15 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update to latest pnpm * 3.0.8 * Fix fee options stub signature (0xsequence#999) * 3.0.9 * Enforce minimum age limitation for packages --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Corban Riley <corbanbrook@gmail.com> Co-authored-by: Taylan Pince <taylanpince@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: tolgahan-arikan <tolgahan.arikan@gmail.com>
* Bump the npm_and_yarn group across 1 directory with 1 update Bumps the npm_and_yarn group with 1 update in the / directory: [express](https://github.com/expressjs/express). Updates `express` from 4.18.2 to 4.19.2 - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.18.2...4.19.2) --- updated-dependencies: - dependency-name: express dependency-type: direct:development dependency-group: npm_and_yarn-security-group ... Signed-off-by: dependabot[bot] <support@github.com> * Create SECURITY.md * Set up CI with Azure Pipelines [skip ci] * Create CNAME * Create fortify.yml * Update issue templates * Update CNAME * Update CNAME * Update CNAME * Update CNAME * update * Update wagmi-project/src/main.tsx Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * Update wagmi-project/package.json Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * Update .github/ISSUE_TEMPLATE/custom.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * Enforce minimum age limitation for packages (#556) * Bump next from 15.5.14 to 15.5.15 (0xsequence#989) Bumps [next](https://github.com/vercel/next.js) from 15.5.14 to 15.5.15. - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](vercel/next.js@v15.5.14...v15.5.15) --- updated-dependencies: - dependency-name: next dependency-version: 15.5.15 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update to latest pnpm * 3.0.8 * Fix fee options stub signature (0xsequence#999) * 3.0.9 * Enforce minimum age limitation for packages --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Taylan Pince <taylanpince@gmail.com> Co-authored-by: tolgahan-arikan <tolgahan.arikan@gmail.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> Co-authored-by: googleworkspace-bot <googleworkspace-bot@google.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Taylan Pince <taylanpince@gmail.com> Co-authored-by: tolgahan-arikan <tolgahan.arikan@gmail.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
* Bump next.js deps to resolve security issue (0xsequence#1000) * Add Claude review workflow (0xsequence#1001) --------- Co-authored-by: Taylan Pince <taylanpince@gmail.com>
* Bump next.js deps to resolve security issue (0xsequence#1000) * Add Claude review workflow (0xsequence#1001) --------- Co-authored-by: Taylan Pince <taylanpince@gmail.com>
* Bump next.js deps to resolve security issue (0xsequence#1000) * Add Claude review workflow (0xsequence#1001) --------- Co-authored-by: Taylan Pince <taylanpince@gmail.com>
|
|
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
This comment was marked as resolved.
This comment was marked as resolved.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Reviewer's GuideAdds a new wagmi-based Vite demo app and various project-scaffolding/configuration artifacts (security and issue templates, CI pipelines, Fortify SAST workflow), plus bumps the indexer service changelog to 2.0.0 with a placeholder entry. Sequence diagram for wagmi wallet connect/disconnect flowsequenceDiagram
actor User
participant App
participant WagmiProvider
participant useConnect
participant useAccount
participant useDisconnect
User->>App: click connector button
App->>useConnect: connect({ connector })
useConnect->>WagmiProvider: connect
WagmiProvider-->>useAccount: update account.status='connected'
useAccount-->>App: account (status, addresses, chainId)
App-->>User: render account info and Disconnect button
User->>App: click Disconnect
App->>useDisconnect: disconnect()
useDisconnect->>WagmiProvider: disconnect
WagmiProvider-->>useAccount: update account.status='disconnected'
useAccount-->>App: account (status)
App-->>User: hide Disconnect button, show Connect buttons
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Code Review
This pull request initializes a new Vite project using create-wagmi and adds various configuration files for CI/CD, CodeSandbox, and GitHub. The review feedback identifies several issues: the Azure pipeline uses an obsolete Node.js version and the wrong package manager, and environment-specific V8 cache artifacts were mistakenly committed. Additionally, the reviewer recommends pinning dependencies to specific versions instead of using the latest tag and suggests validating the WalletConnect project ID environment variable to ensure runtime stability.
There was a problem hiding this comment.
Hey - I've found 2 issues, and left some high level feedback:
- It looks like various generated/cache artifacts (e.g.
v8-compile-cache-0/...bin.js.MAP) and sandbox/infra files (e.g..codesandbox/tasks.json,CNAME) are being committed; consider excluding these via.gitignoreand keeping the PR focused on the actual app and workflow changes. - The Azure pipeline is pinned to Node 10 (
versionSpec: '10.x'), which is long out of support; aligning this to the runtime you actually use (and to what your app expects, e.g. Node 18+) would avoid surprises in the CI environment. - In
wagmi-project/src/wagmi.ts,walletConnectdepends onimport.meta.env.VITE_WC_PROJECT_ID; adding a simple runtime check or failing fast when this env var is missing would make misconfiguration easier to catch.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- It looks like various generated/cache artifacts (e.g. `v8-compile-cache-0/...bin.js.MAP`) and sandbox/infra files (e.g. `.codesandbox/tasks.json`, `CNAME`) are being committed; consider excluding these via `.gitignore` and keeping the PR focused on the actual app and workflow changes.
- The Azure pipeline is pinned to Node 10 (`versionSpec: '10.x'`), which is long out of support; aligning this to the runtime you actually use (and to what your app expects, e.g. Node 18+) would avoid surprises in the CI environment.
- In `wagmi-project/src/wagmi.ts`, `walletConnect` depends on `import.meta.env.VITE_WC_PROJECT_ID`; adding a simple runtime check or failing fast when this env var is missing would make misconfiguration easier to catch.
## Individual Comments
### Comment 1
<location path="wagmi-project/src/wagmi.ts" line_range="5-12" />
<code_context>
+ connectors: [
+ injected(),
+ coinbaseWallet(),
+ walletConnect({ projectId: import.meta.env.VITE_WC_PROJECT_ID }),
+ ],
+ transports: {
</code_context>
<issue_to_address>
**suggestion:** Handle missing or misconfigured `VITE_WC_PROJECT_ID` to avoid runtime failures.
If `VITE_WC_PROJECT_ID` is missing or empty, `walletConnect` will likely fail at runtime in a hard-to-debug way. Consider validating this value when creating the config (e.g., throw a clear error or skip the connector) so misconfiguration is surfaced early.
```suggestion
const wcProjectId = import.meta.env.VITE_WC_PROJECT_ID
if (!wcProjectId) {
// Fail fast with a clear error instead of an opaque runtime failure inside walletConnect
throw new Error(
'VITE_WC_PROJECT_ID is not set. Please define it in your environment to enable WalletConnect.',
)
}
export const config = createConfig({
chains: [mainnet, sepolia],
connectors: [
injected(),
coinbaseWallet(),
walletConnect({ projectId: wcProjectId }),
],
transports: {
```
</issue_to_address>
### Comment 2
<location path="wagmi-project/src/main.tsx" line_range="12" />
<code_context>
+
+import './index.css'
+
+globalThis.Buffer = Buffer
+
+const queryClient = new QueryClient()
</code_context>
<issue_to_address>
**suggestion (bug_risk):** Consider guarding or narrowing the global `Buffer` assignment to avoid unintended overrides.
Unconditionally setting `globalThis.Buffer` can clobber an existing implementation in some environments. Consider guarding it, e.g. `if (!globalThis.Buffer) globalThis.Buffer = Buffer`, so you only provide the polyfill when no `Buffer` is already defined.
```suggestion
if (!globalThis.Buffer) {
globalThis.Buffer = Buffer
}
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Summary by Sourcery
Add a wagmi-based demo app and integrate new security and CI workflows.
New Features:
Enhancements:
Build:
CI:
Deployment:
Documentation:
Chores: