Fix column requirements banner flicker - #856
Merged
Merged
Conversation
cristian-tamblay
approved these changes
Sep 2, 2026
cristian-tamblay
added a commit
that referenced
this pull request
Sep 2, 2026
PrepareDatasetStep conflicted on the same expression from both sides. #856 turned columnsReady from state into a derived value, which is the better shape, but dropped the requiresTarget escape hatch that a task with no output column needs. Kept the derived form with the hatch back inside it, and moved the declaration below requiresTarget: the two are five lines apart in the file and reading it from above would have hit the temporal dead zone on every render. Its new output error is now conditioned on requiresTarget too, so a clustering session no longer paints a red "Required" over a field DivideDatasetColumns does not render for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the input/output column requirements banner in the "Prepare Dataset" step of session creation. It used to vanish silently (no message at all) whenever Input or Output Columns was emptied, and could briefly flash an incorrect red "invalid" state right after a dataset finished loading, even when the auto-selected columns were actually valid. Cleared fields now show an inline "Required" error, and the requirements banner reflects the real validation state without flickering.
Type of Change
Check all that apply like this [x]:
Changes (by file)
DashAI/front/src/components/models/modelSession/PrepareDatasetStep.jsx:inputError/outputError/inputHelperText/outputHelperTextprops onDivideDatasetColumns, so an empty Input/Output Columns field is marked red with a "Required" message instead of the whole requirements banner just disappearing.validationPendingnow resolves tofalseimmediately (we already know the selection is invalid, no backend call needed) instead of getting stuck attrueforever, which was hiding the banner permanently after a column was cleared.useEffecttouseLayoutEffectto close a render race: when columns go from empty back to a valid selection (e.g. right after the dataset finishes loading and defaults are auto-selected), the pending flag now flips back totruesynchronously before paint, instead of one commit too late, which previously caused a one-frame flash of an incorrect red "invalid" banner over already-valid columns.columnsReadyfrom auseState+useEffectpair into a plain derived value, removing an extra render cycle of lag.Testing