Skip to content

deps: bump ebpf-manager to release kernel BTF after program load - #54054

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
mbertrone/bump-ebpf-manager-btf-cache-release
Jul 27, 2026
Merged

deps: bump ebpf-manager to release kernel BTF after program load#54054
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
mbertrone/bump-ebpf-manager-btf-cache-release

Conversation

@mbertrone

Copy link
Copy Markdown
Contributor

What does this PR do?

Bumps github.com/DataDog/ebpf-manager to the commit that releases kernel BTF once eBPF program loading finishes. Manager.Start() now clears both VerifierOptions.Programs.KernelTypes and the shared VerifierOptions.Cache after the collection is loaded (unless the caller opts out via KeepKernelBTF).

Pinned as a temporary pseudo-version (v0.8.1-0.20260723114030-df952c39a4e3) pending the v0.8.1 tag — see DataDog/ebpf-manager#283.

Motivation

A long-lived system-probe kept the parsed kernel vmlinux BTF pinned in the shared verifier cache for the entire process lifetime, even though it is only needed while loading programs. This regressed idle heap/RSS. Releasing the cache after load lets that memory be reclaimed.

Describe how you validated your changes

  • Upstream change carries a unit test (TestReleaseKernelBTF) covering both the default-release and KeepKernelBTF-retain paths.
  • Built system-probe against the pinned version and confirmed it compiles and loads eBPF programs (NPM + USM + CWS) without errors.

Additional Notes

Follow-up: once DataDog/ebpf-manager#283 merges and v0.8.1 is tagged, swap the pseudo-version for the tag and re-run dda inv tidy.

Pin DataDog/ebpf-manager to the commit that clears the shared BTF cache and
KernelTypes spec in Manager.Start() once program loading finishes, so a
long-lived system-probe no longer keeps the parsed kernel vmlinux BTF pinned
for the whole process lifetime (idle-memory regression).

Temporary pseudo-version pending the v0.8.1 tag; see DataDog/ebpf-manager#283.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@dd-octo-sts dd-octo-sts Bot added the internal Identify a non-fork PR label Jul 23, 2026
@github-actions github-actions Bot added the short review PR is simple enough to be reviewed quickly label Jul 23, 2026
@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 52.08% (+0.13%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2567616 | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor c48026b1:

Results for datadog-agent_7.83.0~devel.git.353.2567616.pipeline.126583330-1_amd64.deb:

No change detected

@dd-octo-sts

dd-octo-sts Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor c48026b
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +4.06 KiB (0.00% increase, -0.06% of buffer) 751.290 → 751.294 → 758.200
agent_deb_amd64_fips +4.06 KiB (0.00% increase, -0.09% of buffer) 706.062 → 706.066 → 710.520
agent_rpm_amd64 +4.06 KiB (0.00% increase, -0.06% of buffer) 751.273 → 751.277 → 758.170
agent_rpm_amd64_fips +4.06 KiB (0.00% increase, -0.09% of buffer) 706.046 → 706.050 → 710.520
agent_rpm_arm64 +4.03 KiB (0.00% increase, -0.23% of buffer) 727.928 → 727.932 → 729.660
agent_suse_amd64 +4.06 KiB (0.00% increase, -0.06% of buffer) 751.273 → 751.277 → 758.170
agent_suse_amd64_fips +4.06 KiB (0.00% increase, -0.09% of buffer) 706.046 → 706.050 → 710.520
agent_suse_arm64 +4.03 KiB (0.00% increase, -0.23% of buffer) 727.928 → 727.932 → 729.660
docker_agent_amd64 +4.07 KiB (0.00% increase, -0.10% of buffer) 809.955 → 809.958 → 813.790
docker_agent_arm64 +4.03 KiB (0.00% increase, -0.12% of buffer) 811.656 → 811.660 → 815.030
docker_agent_jmx_amd64 +4.07 KiB (0.00% increase, -0.11% of buffer) 1000.852 → 1000.856 → 1004.550
docker_agent_jmx_arm64 +4.03 KiB (0.00% increase, -0.11% of buffer) 991.206 → 991.210 → 994.710
20 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_heroku_amd64 307.539 MiB
agent_rpm_arm64_fips 685.851 MiB
agent_suse_arm64_fips 685.851 MiB
docker_cluster_agent_amd64 209.866 MiB
docker_cluster_agent_arm64 222.953 MiB
docker_cws_instrumentation_amd64 7.439 MiB
docker_cws_instrumentation_arm64 6.877 MiB
docker_dogstatsd_amd64 39.243 MiB
docker_dogstatsd_arm64 37.368 MiB
docker_host_profiler_amd64 303.876 MiB
docker_host_profiler_arm64 315.371 MiB
dogstatsd_deb_amd64 29.984 MiB
dogstatsd_deb_arm64 28.024 MiB
dogstatsd_rpm_amd64 29.984 MiB
dogstatsd_suse_amd64 29.984 MiB
iot_agent_deb_amd64 46.153 MiB
iot_agent_deb_arm64 42.845 MiB
iot_agent_deb_armhf 43.613 MiB
iot_agent_rpm_amd64 46.154 MiB
iot_agent_suse_amd64 46.153 MiB

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 09ea6b72-f22c-4006-a351-660fccef8e19

Baseline: ae52332
Comparison: 2567616
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_security_no_fs_load memory utilization +0.52 [+0.42, +0.61] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization +0.35 [+0.10, +0.60] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.08 [+0.03, +0.13] 1 Logs bounds checks dashboard
quality_gate_security_mean_fs_load memory utilization +0.02 [-0.02, +0.06] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization -0.19 [-0.24, -0.13] 1 Logs bounds checks dashboard
quality_gate_private_action_runner memory utilization -0.19 [-0.31, -0.07] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -1.29 [-2.29, -0.29] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization -2.52 [-2.56, -2.48] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 147.66MiB ≤ 154MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 734.27KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 489.92MiB ≤ 512MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 1.12MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 187.32MiB ≤ 195MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 264.15MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 374.48 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 406.63MiB ≤ 430MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.94GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_private_action_runner memory_usage 10/10 71.48MiB ≤ 75MiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 30.77 ≤ 100 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 299.55MiB ≤ 330MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 66.23 ≤ 200 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 277.37MiB ≤ 310MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 22.45 ≤ 100 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 288.04MiB ≤ 320MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment Variant Replicates Failure Logs Debug Dashboard
experiment_with_failures baseline 0 (x8) 1 (x6) Oom killed Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment Variant Replicates Failure Debug Dashboard
quality_gate_idle baseline 10 Oom killed Debug Dashboard
quality_gate_idle comparison 10 Oom killed Debug Dashboard
quality_gate_idle_all_features baseline 10 Oom killed Debug Dashboard
quality_gate_idle_all_features comparison 10 Oom killed Debug Dashboard
quality_gate_logs baseline 10 Oom killed Debug Dashboard
quality_gate_logs comparison 10 Oom killed Debug Dashboard
quality_gate_metrics_logs baseline 10 Oom killed Debug Dashboard
quality_gate_metrics_logs comparison 10 Oom killed Debug Dashboard
quality_gate_security_idle baseline 10 Crashed (exit code: 134) Debug Dashboard
quality_gate_security_idle comparison 10 Crashed (exit code: 134) Debug Dashboard
quality_gate_security_no_fs_load baseline 10 Crashed (exit code: 134) Debug Dashboard
quality_gate_security_no_fs_load comparison 10 Oom killed Debug Dashboard

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.

@mbertrone mbertrone self-assigned this Jul 24, 2026
@mbertrone mbertrone added changelog/no-changelog No changelog entry needed team/ebpf-platform qa/skip-qa qa/done QA done before merge and regressions are covered by tests labels Jul 24, 2026
@mbertrone
mbertrone requested review from a team and GeorgeHahn July 24, 2026 12:54
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit c619dcb into main Jul 27, 2026
291 of 302 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the mbertrone/bump-ebpf-manager-btf-cache-release branch July 27, 2026 15:04
@github-actions github-actions Bot added this to the 7.83.0 milestone Jul 27, 2026
charan-manjunath pushed a commit that referenced this pull request Aug 25, 2026
)

### What does this PR do?

Bumps `github.com/DataDog/ebpf-manager` to the commit that releases kernel BTF once eBPF program loading finishes. `Manager.Start()` now clears both `VerifierOptions.Programs.KernelTypes` and the shared `VerifierOptions.Cache` after the collection is loaded (unless the caller opts out via `KeepKernelBTF`).

Pinned as a temporary pseudo-version (`v0.8.1-0.20260723114030-df952c39a4e3`) pending the `v0.8.1` tag — see DataDog/ebpf-manager#283.

### Motivation

A long-lived `system-probe` kept the parsed kernel vmlinux BTF pinned in the shared verifier cache for the entire process lifetime, even though it is only needed while loading programs. This regressed idle heap/RSS. Releasing the cache after load lets that memory be reclaimed.

### Describe how you validated your changes

- Upstream change carries a unit test (`TestReleaseKernelBTF`) covering both the default-release and `KeepKernelBTF`-retain paths.
- Built `system-probe` against the pinned version and confirmed it compiles and loads eBPF programs (NPM + USM + CWS) without errors.

### Additional Notes

Follow-up: once DataDog/ebpf-manager#283 merges and `v0.8.1` is tagged, swap the pseudo-version for the tag and re-run `dda inv tidy`.


Co-authored-by: matteo.bertrone <matteo.bertrone@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR qa/done QA done before merge and regressions are covered by tests qa/skip-qa short review PR is simple enough to be reviewed quickly team/ebpf-platform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants