test(test-optimization): skip unsupported v5 Mocha cases - #9834
Conversation
Overall package sizeSelf size: 8.2 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.3.3 | 125.43 kB | 445.14 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
![datadog-official[bot]](https://avatars.githubusercontent.com/in/1358509?s=60&v=4){kind=small}
There was a problem hiding this comment.
More details
The predicate resolves oldest to Mocha 5.2.0 before gating and also requires dd-trace v5, so only the two documented unsupported cases lose coverage; v5/latest and every v6 matrix remain active.
🤖 Datadog Autotest · Commit 6d243e2 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6d243e28a8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }) | ||
|
|
||
| it('tests with retries', async () => { | ||
| reporterFinalizationIt('tests with retries', async () => { |
There was a problem hiding this comment.
When the v5 oldest-version CI leg resolves MOCHA_VERSION=oldest to 5.2.0, this change skips the entire pre-existing retry test even though the test contains explicit expectations for Mocha versions below 6. The new TODO acknowledges that this is a regression introduced by #9798, so skipping the test hides a deterministic regression in a supported v5 configuration and removes the remaining CI coverage for Mocha 5 retry reporting; keep this test enabled and fix or version-gate the underlying finalization behavior instead.
AGENTS.md reference: AGENTS.md:L345-L349
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
This PR intentionally only skips the failing v5 cases to unblock the release, following #9821. The underlying Mocha 5 behavior can be addressed separately.
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 6d243e2 | Docs | Datadog PR Page | Give us feedback! |
BenchmarksBenchmark execution time: 2026-08-17 08:57:23 Comparing candidate commit 6d243e2 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 2281 metrics, 11 unstable metrics.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9834 +/- ##
========================================
Coverage 98.53% 98.53%
========================================
Files 975 975
Lines 144148 144148
Branches 12448 12813 +365
========================================
Hits 142031 142031
Misses 2117 2117 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 participants
What does this PR do?
afterAllfinalization test for dd-trace v5 with Mocha 5.2.Motivation
The v5 release proposal fails with older Mocha versions that do not support the lifecycle behavior introduced in #9762 and #9797. The supported v5 versions and v6 continue to run these tests.