fix(llmobs): preserve in-flight dataset mutations - #9903
Conversation
Overall package sizeSelf size: 8.41 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.3.3 | 125.43 kB | 445.14 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 92ea840837
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
✅ All CI checks and tests passed. 🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 600c871 | Docs | View more details | Give us feedback! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 60a842454e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
BenchmarksBenchmark execution time: 2026-08-26 19:26:43 Comparing candidate commit 600c871 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 2300 metrics, 10 unstable metrics.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9903 +/- ##
========================================
Coverage 98.57% 98.57%
========================================
Files 990 990
Lines 148942 148949 +7
Branches 12978 12806 -172
========================================
+ Hits 146821 146828 +7
Misses 2121 2121
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Codex's snapshotting feedback is addressed in 60a8424: batch snapshots now use a JSON round trip matching the request serialization path, including custom The remaining CI failures are unrelated to this PR: |
|
Follow-up for CI: the |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2db5c070d2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Follow-up complete: Codex feedback on JSON serialization context and direct tag mutations is addressed in 190b3a7, with regression tests. All review threads are resolved. After rerunning the transient system-test and aggregate checks, all required checks are green: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1eacb52b8f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
* fix(llmobs): snapshot dataset batch payloads * fix(llmobs): preserve JSON serialization in snapshots * test(llmobs): support updated AI tool span parents * fix(llmobs): reconcile inserted field and tag changes * fix(llmobs): use rfdc for dataset snapshots * refactor(llmobs): bind rfdc as snapshotPayload
* fix(llmobs): snapshot dataset batch payloads * fix(llmobs): preserve JSON serialization in snapshots * test(llmobs): support updated AI tool span parents * fix(llmobs): reconcile inserted field and tag changes * fix(llmobs): use rfdc for dataset snapshots * refactor(llmobs): bind rfdc as snapshotPayload
* fix(llmobs): snapshot dataset batch payloads * fix(llmobs): preserve JSON serialization in snapshots * test(llmobs): support updated AI tool span parents * fix(llmobs): reconcile inserted field and tag changes * fix(llmobs): use rfdc for dataset snapshots * refactor(llmobs): bind rfdc as snapshotPayload
* fix(llmobs): snapshot dataset batch payloads * fix(llmobs): preserve JSON serialization in snapshots * test(llmobs): support updated AI tool span parents * fix(llmobs): reconcile inserted field and tag changes * fix(llmobs): use rfdc for dataset snapshots * refactor(llmobs): bind rfdc as snapshotPayload
4 participants
What does this PR do?
Raised by this Codex review: #9762 (comment) Deeply snapshots dataset insert and update payloads before sending a batch request. This keeps the committed batch independent from live DatasetRecord values, so nested object/array mutations made while push() is in flight remain pending for a subsequent push.
Testing
./node_modules/.bin/mocha packages/dd-trace/test/llmobs/experiments/experiment.spec.jsReview notes
rfdcfollowing BridgeAR's review comment.