-
Notifications
You must be signed in to change notification settings - Fork 542
fix(profiling): avoid crashing stack sampler with active foreign SIGSEGV handlers (PROF-15342) #18798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gh-worker-dd-mergequeue-cf854d
merged 29 commits into
main
from
vlad/prof-14568-handler-ownership
Jul 23, 2026
Merged
fix(profiling): avoid crashing stack sampler with active foreign SIGSEGV handlers (PROF-15342) #18798
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
0e4003a
fix(profiling): harden stack sampler against foreign SIGSEGV handlers
vlad-scherbich 76013f3
test(profiling): drop warmup env override; add handler-ownership intr…
vlad-scherbich 12cae40
test(profiling): update fast-copy stat test for the startup warmup
vlad-scherbich 2c5ea5f
fix(profiling): check SIGSEGV and SIGBUS ownership; stop sampling whe…
vlad-scherbich 96da0aa
fix lints
vlad-scherbich d3b315b
docs(profiling): tie foreign-handler fix to PROF-14568 findings
vlad-scherbich cd95947
fix(profiling): do not stomp a foreign fault handler at sampler start
vlad-scherbich 93a7c26
chore(profiling): drop PROF-14568 repro script from PR
vlad-scherbich 6cf6b18
style: apply clang-format 18.1.5 to stack sampler fault-handler code
vlad-scherbich fcdf250
stubs(profiling): add segv_handler_installed to _stack.pyi
vlad-scherbich d99a702
shorten release note
vlad-scherbich d5248bd
test(profiling): observe fast-copy upgrade via native introspection
vlad-scherbich f70f110
shorten comments and improve tests
vlad-scherbich 8caced0
fix(profiling): reorder Sampler fields to satisfy clang-tidy padding …
vlad-scherbich 263be87
fix(profiling): validate warmup setter input and skip test when stack…
vlad-scherbich a73661d
Thomas and bot comments addressed
vlad-scherbich 192efca
review: apply suggestion
KowalskiThomas 846d798
review: apply suggestion
KowalskiThomas b6e1d89
review: apply suggestion
KowalskiThomas 741dd84
review: apply suggestion
KowalskiThomas 8371811
review: apply suggestion
KowalskiThomas 89ed7db
review: apply suggestion
KowalskiThomas 0156162
review: apply suggestion
KowalskiThomas acc7363
feat(profiling): add ProfilerStats metrics for fast-copy fallback obs…
vlad-scherbich 51c0105
fix(profiling): preserve fast-copy metadata across stats swaps
vlad-scherbich 5bd63f3
style(profiling): clang-format sampler.hpp
vlad-scherbich fd5fd49
update comment and release note
vlad-scherbich 61b81a0
fix lint
vlad-scherbich 98c1492
Merge branch 'main' into vlad/prof-14568-handler-ownership
vlad-scherbich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
|
vlad-scherbich marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
vlad-scherbich marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.