Skip to content

fix(civisibility): log test-management request timing and bump timeou… - #19860

Draft
gnufede wants to merge 2 commits into
mainfrom
gnufede/test-management-timeout
Draft

fix(civisibility): log test-management request timing and bump timeou…#19860
gnufede wants to merge 2 commits into
mainfrom
gnufede/test-management-timeout

Conversation

@gnufede

@gnufede gnufede commented Aug 25, 2026

Copy link
Copy Markdown
Member

…t to 3s

  • Log the elapsed time (and error type) of the test-management tests request so we can confirm whether failures are genuinely above the DD_CIVISIBILITY_BACKEND_API_TIMEOUT_MILLIS budget and investigate why.
  • Raise DD_CIVISIBILITY_BACKEND_API_TIMEOUT_MILLIS from 2000ms to 3000ms in the riotfile base env to see if the extra second resolves the timeouts.

Description

Testing

Risks

Additional Notes

…t to 3s

- Log the elapsed time (and error type) of the test-management tests
  request so we can confirm whether failures are genuinely above the
  DD_CIVISIBILITY_BACKEND_API_TIMEOUT_MILLIS budget and investigate why.
- Raise DD_CIVISIBILITY_BACKEND_API_TIMEOUT_MILLIS from 2000ms to 3000ms
  in the riotfile base env to see if the extra second resolves the
  timeouts.
@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Codeowners resolved as

Resolved from the full PR diff against main using the target branch CODEOWNERS file.
CODEOWNERS team requests not listed below are not required by the current file set.

ddtrace/testing/internal/api_client.py                                  @DataDog/ci-app-libraries
ddtrace/testing/internal/http.py                                        @DataDog/ci-app-libraries
riotfile.py                                                             @DataDog/apm-python
tests/testing/internal/test_api_client.py                               @DataDog/ci-app-libraries
tests/testing/mocks.py                                                  @DataDog/ci-app-libraries

@datadog-datadog-us1-prod

datadog-datadog-us1-prod Bot commented Aug 25, 2026

Copy link
Copy Markdown

Pipelines  Tests

⚠️ Warnings

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 24 Pipeline jobs failed

Configuration Registry | Check supported-configurations.json — 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

Missing entries in supported-configurations.json for variable '_DD_CIVISIBILITY_TEST_MANAGEMENT_TESTS_TIMEOUT_MILLIS'.

Changelog | Validate changelog

View more details · View in GitHub Actions

Release note not found during changelog validation.

DataDog/apm-reliability/dd-trace-py | benchmarks-pr-comment

View more details · View in GitLab

View all 24 failed jobs.

📋 Copy fix prompt
CI on my pull request is failing. Help me find and fix the root cause of each failing job below — they were flagged as caused by changes in this PR, so focus on the diff. For each job, explain the failure and propose a fix.

Before you start, set up the Datadog software-delivery tooling so you can
query the CI data yourself:

1. Check whether you already have the Datadog software-delivery MCP tools
   (e.g. a `search_datadog_ci_pipeline_events` tool) and the `unblock-pr` skill.
2. If either is missing, STOP and ask me for permission before installing
   anything. Do not install or run anything until I have said yes.
3. Only with my explicit approval, set up the Datadog software-delivery MCP
   server and skills by following:
     https://docs.datadoghq.com/getting_started/software_delivery_mcp_tools/
   then restart so the skill is picked up.
4. If I decline, skip all of the above and work from the context below alone.

Then run /unblock-pr — it will pull the CI data itself. The job context below is what we already know.

If /unblock-pr is not available — because I declined the setup above, or it did not install — work from the context below instead.

Datadog has already classified this failure as caused by changes in this PR.
Take that as given and work the fix:

1. Locate the change. Diff this branch against its base and find the change
   that produces this error. Explain the mechanism, don't just name a file:
     git fetch origin && git diff $(git merge-base origin/main HEAD)...HEAD
2. Reproduce it locally. Run the failing job's command or test before
   proposing anything.
3. Propose the smallest fix that addresses the root cause — not a workaround,
   not a broadened assertion, not a disabled or skipped test.
4. Re-run the same command to confirm, and say exactly what you ran.
5. If the failure turns out to be intermittent rather than deterministic, say
   so plainly instead of "fixing" it — that is a flaky test, and patching it
   hides the problem.

If the right move is to re-run the job rather than change code, use the job
link in the context below. For GitHub Actions: `gh run rerun <run-id> --failed`,
where the run ID is the number after `/runs/` in that URL (not the trailing
number, which is the job ID).

Branch: gnufede/test-management-timeout

Configuration Registry | Check supported-configurations.json
Commit: 748ae889ed05ce9ef32e6f61b3e32557e5849799
Error (code / build):
Missing entries in supported-configurations.json for variable '_DD_CIVISIBILITY_TEST_MANAGEMENT_TESTS_TIMEOUT_MILLIS'.
CI job: https://github.com/DataDog/dd-trace-py/actions/runs/32868249404/job/97868738897

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog auto-retried 15 jobs - 15 passed on retry View in Datadog

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5008a29 | Docs | View more details | Give us feedback!

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Circular import analysis

⚠️ Existing circular imports

There are 3 circular imports that already exist on the base branch and have not been changed by this PR.

ddtrace.llmobs -> ddtrace.llmobs._evaluators -> ddtrace.llmobs._evaluators.format -> ddtrace.llmobs._experiment -> ddtrace.llmobs
ddtrace.errortracking._handled_exceptions.bytecode_injector -> ddtrace.errortracking._handled_exceptions.callbacks -> ddtrace.errortracking._handled_exceptions.collector -> ddtrace.errortracking._handled_exceptions.bytecode_reporting -> ddtrace.errortracking._handled_exceptions.bytecode_injector
ddtrace.appsec._asm_request_context -> ddtrace.appsec._iast._iast_request_context_base -> ddtrace.appsec._iast._iast_env -> ddtrace.appsec._iast.reporter -> ddtrace.appsec._exploit_prevention.stack_traces -> ddtrace.appsec._asm_request_context

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Dependency direction analysis

⚠️ Existing dependency direction violations

There are 249 dependency direction violations that already exist on the base branch and have not been changed by this PR.

Show existing violations (showing 5 of 249 highest severity)
ddtrace.internal.tracemethods -×-> ddtrace.trace  (internal-core -> product:tracing, score=135)
ddtrace.llmobs._integrations.base -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)
ddtrace.llmobs._integrations.openai -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)
ddtrace.profiling.collector.pytorch -×-> ddtrace.trace  (product:profiling -> product:tracing, score=133)
ddtrace.llmobs._utils -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)

To see all violations, download the layers-base.json and layers-pr.json artifacts from this CI job and run:

uv run --script scripts/import-analysis/layers.py compare layers-base.json layers-pr.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant