chore: convert existing AIDEV-* anchors to plain comments by vlad-scherbich · Pull Request #19877 · DataDog/dd-trace-py

vlad-scherbich · 2026-08-26T17:36:09Z

Description

Split of #19517, slice 2 of 2 (deprecate existing). Independent of the CI/docs PR that blocks new anchors.

Converts remaining AIDEV-NOTE: / AIDEV-TODO: / AIDEV-QUESTION: prefixes in the files #19517 rewrote, on current main:

AIDEV-NOTE: stripped; comment text kept
AIDEV-TODO: kept as TODO:
AIDEV-QUESTION: in taint_engine_context.h kept as TODO: (same net as chore(docs): deprecate existing AIDEV anchor labels and block new ones #19517 commits 2+3)

Comment-only except:

setup.cfg: add fpr to codespell ignore-words (needed because staging docker/Dockerfile scans GPG fpr: lines; this was in chore(docs): deprecate existing AIDEV anchor labels and block new ones #19517)
mypy.ini: ignore_errors for test modules the pre-commit mypy hook typechecks when those tests are staged. Default mypy files is only ddtrace/ and docs/; these errors are pre-existing and not introduced by the comment edits. Not in original chore(docs): deprecate existing AIDEV anchor labels and block new ones #19517; required to land the rewrite with current hooks.

Two files from #19517 were already clean on current main and are omitted: ddtrace/profiling/collector/_memalloc_tb.cpp, and the rest of setup.cfg besides fpr.

This PR does not add the CI check or AGENTS.md policy. Merge order vs the block-new PR does not matter.

Testing

Pre-commit hooks passed on this branch (format/lint, mypy, codespell, bandit, ast-grep)
Spot-check a few converted comments still read as the original invariant text
Confirm AIDEV-NOTE / AIDEV-TODO / AIDEV-QUESTION prefixes are gone from the chore(docs): deprecate existing AIDEV anchor labels and block new ones #19517 rewrite paths (docs/rules live on the other PR)

Risks

Low. Comment-label rewrite; no runtime behavior change. Broad CODEOWNERS blast radius (asm, llmobs, profiling, ci-app, core) because the original hits were scattered — that is why this is split from the small CI PR.

Additional Notes

Independent of vlad/block-new-aidev-anchors (both branch from main; no stack)
Original combined PR left open: chore(docs): deprecate existing AIDEV anchor labels and block new ones #19517 (vlad/check-no-new-aidev-anchors)
AIDEV hits added on main after chore(docs): deprecate existing AIDEV anchor labels and block new ones #19517 in files that PR did not touch are not converted here (for example ddtrace/llmobs/_integrations/agent_manifest.py, ddtrace/internal/sampling.py, src/native/http_client/client.rs). The block-new PR grandfathers them.

Convert deprecated AIDEV-NOTE/TODO/QUESTION anchors to plain inline comments, preserving the underlying comment text. Independent of the CI check that blocks new anchors.

cit-pr-commenter-54b7da · 2026-08-26T17:36:20Z

Codeowners resolved as

Resolved from the full PR diff against main using the target branch CODEOWNERS file.
CODEOWNERS team requests not listed below are not required by the current file set.

ddtrace/_trace/subscribers/http_client.py                               @DataDog/apm-sdk-capabilities-python @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/aiguard/__init__.py                                             @DataDog/asm-python
ddtrace/aiguard/_listener.py                                            @DataDog/asm-python
ddtrace/aiguard/_streaming.py                                           @DataDog/asm-python
ddtrace/aiguard/integrations/_anthropic.py                              @DataDog/asm-python
ddtrace/aiguard/integrations/_anthropic_errors.py                       @DataDog/asm-python
ddtrace/aiguard/integrations/_langchain.py                              @DataDog/asm-python
ddtrace/aiguard/integrations/_openai.py                                 @DataDog/asm-python
ddtrace/aiguard/integrations/_openai_errors.py                          @DataDog/asm-python
ddtrace/aiguard/integrations/_openai_responses.py                       @DataDog/asm-python
ddtrace/aiguard/integrations/litellm.py                                 @DataDog/asm-python
ddtrace/aiguard/integrations/strands.py                                 @DataDog/asm-python
ddtrace/appsec/_constants.py                                            @DataDog/asm-python
ddtrace/appsec/_iast/_taint_tracking/__init__.py                        @DataDog/asm-python
ddtrace/appsec/_iast/_taint_tracking/context/taint_engine_context.h     @DataDog/asm-python
ddtrace/appsec/_iast/_taint_tracking/tests/test_taint_engine_context.cpp  @DataDog/asm-python
ddtrace/appsec/ai_guard/__init__.py                                     @DataDog/asm-python
ddtrace/contrib/internal/aiobotocore/patch.py                           @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/anthropic/patch.py                             @DataDog/ml-observability
ddtrace/contrib/internal/aws_durable_execution_sdk_python/patch.py      @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/aws_durable_execution_sdk_python/trace_checkpoint.py  @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/botocore/patch.py                              @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/botocore/services/kinesis.py                   @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/claude_agent_sdk/_streaming.py                 @DataDog/ml-observability
ddtrace/contrib/internal/coverage/patch.py                              @DataDog/ci-app-libraries
ddtrace/contrib/internal/grpc/aio_client_interceptor.py                 @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/langchain/utils.py                             @DataDog/ml-observability
ddtrace/contrib/internal/langgraph/patch.py                             @DataDog/ml-observability
ddtrace/contrib/internal/openai_agents/patch.py                         @DataDog/ml-observability
ddtrace/contrib/internal/pytest/_plugin_v2.py                           @DataDog/ci-app-libraries
ddtrace/contrib/internal/pytorch/_distributed.py                        @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/internal/_threads.cpp                                           @DataDog/apm-core-python
ddtrace/internal/ci_visibility/recorder.py                              @DataDog/ci-app-libraries
ddtrace/internal/coverage/code.py                                       @DataDog/ci-app-libraries
ddtrace/internal/coverage/instrumentation_py3_12.py                     @DataDog/ci-app-libraries
ddtrace/internal/datastreams/google_cloud_pubsub.py                     @DataDog/data-streams-monitoring
ddtrace/internal/openfeature/_provider.py                               @DataDog/feature-flagging-and-experimentation-sdk
ddtrace/internal/packages.py                                            @DataDog/apm-core-python
ddtrace/internal/settings/_config.py                                    @DataDog/python-guild @DataDog/apm-sdk-capabilities-python
ddtrace/internal/settings/env.py                                        @DataDog/apm-sdk-capabilities-python
ddtrace/internal/test_visibility/coverage_report_utils.py               @DataDog/ci-app-libraries
ddtrace/llmobs/_eval_metric.py                                          @DataDog/ml-observability
ddtrace/llmobs/_integrations/base_stream_handler.py                     @DataDog/ml-observability
ddtrace/llmobs/_integrations/openai_agents.py                           @DataDog/ml-observability
ddtrace/llmobs/_integrations/pydantic_ai.py                             @DataDog/ml-observability
ddtrace/profiling/_gevent.py                                            @DataDog/profiling-python
ddtrace/profiling/collector/_memalloc_frame.h                           @DataDog/profiling-python
ddtrace/testing/internal/cached_file_provider.py                        @DataDog/ci-app-libraries
ddtrace/testing/internal/env_tags.py                                    @DataDog/ci-app-libraries
ddtrace/testing/internal/pytest/plugin.py                               @DataDog/ci-app-libraries
ddtrace/testing/internal/pytest/xdist.py                                @DataDog/ci-app-libraries
ddtrace/testing/internal/session_manager.py                             @DataDog/ci-app-libraries
docker/Dockerfile                                                       @DataDog/python-guild
mypy.ini                                                                @DataDog/python-guild @DataDog/apm-core-python
riotfile.py                                                             @DataDog/apm-python
setup.cfg                                                               @DataDog/python-guild
tests/aiguard/langchain/test_langchain.py                               @DataDog/asm-python
tests/appsec/appsec/test_processor.py                                   @DataDog/asm-python
tests/appsec/iast/aspects/test_modulo_aspect_fixtures.py                @DataDog/asm-python
tests/appsec/iast/test_taint_pyobject_refcount.py                       @DataDog/asm-python
tests/appsec/integrations/django_tests/django_app/views.py              @DataDog/asm-python
tests/appsec/integrations/django_tests/test_iast_django_testagent.py    @DataDog/asm-python
tests/appsec/integrations/fastapi_tests/test_iast_mcp_testagent.py      @DataDog/asm-python
tests/appsec/integrations/flask_tests/test_sca_flask_testagent.py       @DataDog/asm-python
tests/ci_visibility/api_client/_util.py                                 @DataDog/ci-app-libraries
tests/ci_visibility/api_client/test_ci_visibility_api_client.py         @DataDog/ci-app-libraries
tests/ci_visibility/conftest.py                                         @DataDog/ci-app-libraries
tests/ci_visibility/test_ci_visibility.py                               @DataDog/ci-app-libraries
tests/ci_visibility/test_coverage_report_utils.py                       @DataDog/ci-app-libraries
tests/contrib/aiobotocore/test_aws_sigv4_propagation.py                 @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/asynctest/test_asynctest.py                               @DataDog/ci-app-libraries
tests/contrib/llama_index/test_llama_index_patch.py                     @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/pytest/test_pytest.py                                     @DataDog/ci-app-libraries
tests/contrib/ray_serve/test_ray_serve_multi_app.py                     @DataDog/apm-core-python @DataDog/apm-idm-python
tests/coverage/test_instrumentation_py312_disable.py                    @DataDog/ci-app-libraries
tests/datastreams/test_processor.py                                     @DataDog/data-streams-monitoring
tests/testing/internal/pytest/test_pytest_bdd.py                        @DataDog/ci-app-libraries
tests/testing/internal/pytest/test_pytest_xdist.py                      @DataDog/ci-app-libraries
tests/testing/internal/test_http.py                                     @DataDog/ci-app-libraries

cit-pr-commenter-54b7da · 2026-08-26T17:36:32Z

Dependency direction analysis

⚠️ Existing dependency direction violations

There are 240 dependency direction violations that already exist on the base branch and have not been changed by this PR.

Show existing violations (showing 5 of 240 highest severity)

ddtrace.internal.tracemethods -×-> ddtrace.trace  (internal-core -> product:tracing, score=135)
ddtrace.llmobs._evaluators.runner -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)
ddtrace.llmobs._integrations.mcp -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)
ddtrace.internal.openfeature._span_enrichment -×-> ddtrace.trace  (product:openfeature -> product:tracing, score=133)
ddtrace.llmobs._integrations.bedrock_agents -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)

To see all violations, download the layers-base.json and layers-pr.json artifacts from this CI job and run:
uv run --script scripts/import-analysis/layers.py compare layers-base.json layers-pr.json

cit-pr-commenter-54b7da · 2026-08-26T17:36:37Z

Circular import analysis

⚠️ Existing circular imports

There are 3 circular imports that already exist on the base branch and have not been changed by this PR.

ddtrace.llmobs -> ddtrace.llmobs._evaluators -> ddtrace.llmobs._evaluators.format -> ddtrace.llmobs._experiment -> ddtrace.llmobs
ddtrace.errortracking._handled_exceptions.bytecode_injector -> ddtrace.errortracking._handled_exceptions.callbacks -> ddtrace.errortracking._handled_exceptions.collector -> ddtrace.errortracking._handled_exceptions.bytecode_reporting -> ddtrace.errortracking._handled_exceptions.bytecode_injector
ddtrace.appsec._asm_request_context -> ddtrace.appsec._iast._iast_request_context_base -> ddtrace.appsec._iast._iast_env -> ddtrace.appsec._iast.reporter -> ddtrace.appsec._exploit_prevention.stack_traces -> ddtrace.appsec._asm_request_context

datadog-prod-us1-4 · 2026-08-26T17:45:51Z

⚠️ Warnings

❌ Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 5 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-py | build linux serverless: [arm64, cp315-cp315, v113741357-d2b8243-manylinux2014_aarch64, 1] — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

Changelog | Validate changelog

View more details · View in GitHub Actions

Release note not found.

DataDog/apm-reliability/dd-trace-py | build linux serverless: [amd64, cp315-cp315, v113741238-d2b8243-manylinux2014_x86_64, 1]

View more details · View in GitLab

View all 5 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog auto-retried 1 job - 1 passed on retry

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 274da22 | Docs | View more details | Give us feedback!}

pr-commenter · 2026-08-26T18:11:10Z

Benchmarks

Benchmark execution time: 2026-08-26 18:11:07

Comparing candidate commit 274da22 in PR branch vlad/remove-existing-aidev-anchors with baseline commit 85486fa in branch main.

📊 Benchmarking dashboard

Found 0 performance improvements and 5 performance regressions! Performance is the same for 579 metrics, 10 unstable metrics, 2 known flaky benchmarks, 16 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

🟩 = significantly better candidate vs. baseline
🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:httppropagationinject-ids_only

🟥 execution_time [+2.290µs; +2.434µs] or [+13.978%; +14.857%]

scenario:iastaspects-rstrip_aspect

🟥 execution_time [+66.174µs; +76.014µs] or [+17.070%; +19.609%]

scenario:iastaspectsospath-ospathbasename_aspect

🟥 execution_time [+119.812µs; +125.084µs] or [+30.507%; +31.850%]

scenario:telemetryaddmetric-1-count-metric-1-times

🟥 execution_time [+573.570ns; +626.579ns] or [+21.469%; +23.453%]

scenario:tracer-small

🟥 execution_time [+33.892µs; +36.662µs] or [+10.675%; +11.548%]

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:coreapiscenario-context_with_data_listeners

unstable execution_time [-752.785ns; +729.660ns] or [-6.808%; +6.599%]

scenario:coreapiscenario-core_dispatch_1_listener

unstable execution_time [-30.198ns; +35.935ns] or [-4.986%; +5.933%]

scenario:coreapiscenario-core_dispatch_50_listeners

unstable execution_time [-1709.018ns; +1595.592ns] or [-10.021%; +9.356%]

scenario:coreapiscenario-core_dispatch_exception_listeners

unstable execution_time [-986.525ns; +1528.711ns] or [-7.647%; +11.850%]

scenario:coreapiscenario-core_dispatch_listeners

unstable execution_time [-333.806ns; +317.243ns] or [-9.123%; +8.670%]

scenario:coreapiscenario-core_dispatch_no_args_listeners

unstable execution_time [-252.308ns; +252.518ns] or [-8.713%; +8.720%]

scenario:coreapiscenario-core_dispatch_with_results_1_listener

unstable execution_time [-71.196ns; +73.564ns] or [-5.947%; +6.145%]

scenario:coreapiscenario-core_dispatch_with_results_50_listeners

unstable execution_time [-3959.158ns; +4131.447ns] or [-9.581%; +9.998%]

scenario:coreapiscenario-core_dispatch_with_results_listeners

unstable execution_time [-738.597ns; +799.243ns] or [-9.032%; +9.774%]

scenario:packagesupdateimporteddependencies-import_many_stdlib_cached

unstable execution_time [-63.845µs; +54.099µs] or [-10.194%; +8.638%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:iastaspects-swapcase_aspect

🟥 execution_time [+38.897µs; +46.077µs] or [+14.496%; +17.172%]

scenario:span-start

🟥 execution_time [+1.491ms; +1.735ms] or [+11.082%; +12.895%]

Known flaky benchmarks without significant changes:

scenario:errortrackingflasksqli-baseline
scenario:flasksimple-iast-get
scenario:iastaspects-casefold_aspect
scenario:iastaspects-casefold_noaspect
scenario:iastaspects-index_aspect
scenario:iastaspects-ljust_noaspect
scenario:iastaspects-lower_aspect
scenario:iastaspects-replace_aspect
scenario:iastaspects-title_noaspect
scenario:iastaspects-translate_aspect
scenario:iastaspects-translate_noaspect
scenario:iastaspects-upper_noaspect
scenario:packagespackageforrootmodulemapping-cache_off
scenario:packagespackageforrootmodulemapping-cache_on
scenario:sethttpmeta-all-enabled
scenario:telemetryaddmetric-record-100-metrics

chore: convert existing AIDEV-* anchors to plain comments

274da22

Convert deprecated AIDEV-NOTE/TODO/QUESTION anchors to plain inline comments, preserving the underlying comment text. Independent of the CI check that blocks new anchors.

Navigation Menu

Uh oh!

chore: convert existing AIDEV-* anchors to plain comments - #19877

chore: convert existing AIDEV-* anchors to plain comments#19877
vlad-scherbich wants to merge 1 commit into
mainfrom
vlad/remove-existing-aidev-anchors

vlad-scherbich commented Aug 26, 2026

Uh oh!

cit-pr-commenter-54b7da Bot commented Aug 26, 2026

Uh oh!

cit-pr-commenter-54b7da Bot commented Aug 26, 2026

Uh oh!

cit-pr-commenter-54b7da Bot commented Aug 26, 2026

Uh oh!

datadog-prod-us1-4 Bot commented Aug 26, 2026 •

edited by datadog-datadog-prod-us1-2 Bot

Loading

Uh oh!

pr-commenter Bot commented Aug 26, 2026

Explanation

More details about the CI and significant changes

Unstable benchmarks

scenario:coreapiscenario-context_with_data_listeners

scenario:coreapiscenario-core_dispatch_1_listener

scenario:coreapiscenario-core_dispatch_50_listeners

scenario:coreapiscenario-core_dispatch_exception_listeners

scenario:coreapiscenario-core_dispatch_listeners

scenario:coreapiscenario-core_dispatch_no_args_listeners

scenario:coreapiscenario-core_dispatch_with_results_1_listener

scenario:coreapiscenario-core_dispatch_with_results_50_listeners

scenario:coreapiscenario-core_dispatch_with_results_listeners

scenario:packagesupdateimporteddependencies-import_many_stdlib_cached

Known flaky benchmarks

scenario:iastaspects-swapcase_aspect

scenario:span-start

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

vlad-scherbich commented Aug 26, 2026

Description

Testing

Risks

Additional Notes

Uh oh!

cit-pr-commenter-54b7da Bot commented Aug 26, 2026

Codeowners resolved as

Uh oh!

cit-pr-commenter-54b7da Bot commented Aug 26, 2026

Dependency direction analysis

⚠️ Existing dependency direction violations

Uh oh!

cit-pr-commenter-54b7da Bot commented Aug 26, 2026

Circular import analysis

⚠️ Existing circular imports

Uh oh!

datadog-prod-us1-4 Bot commented Aug 26, 2026 • edited by datadog-datadog-prod-us1-2 Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Warnings

ℹ️ Info

Uh oh!

pr-commenter Bot commented Aug 26, 2026

Benchmarks

Explanation

More details about the CI and significant changes

scenario:httppropagationinject-ids_only

scenario:iastaspects-rstrip_aspect

scenario:iastaspectsospath-ospathbasename_aspect

scenario:telemetryaddmetric-1-count-metric-1-times

scenario:tracer-small

Unstable benchmarks

scenario:coreapiscenario-context_with_data_listeners

scenario:coreapiscenario-core_dispatch_1_listener

scenario:coreapiscenario-core_dispatch_50_listeners

scenario:coreapiscenario-core_dispatch_exception_listeners

scenario:coreapiscenario-core_dispatch_listeners

scenario:coreapiscenario-core_dispatch_no_args_listeners

scenario:coreapiscenario-core_dispatch_with_results_1_listener

scenario:coreapiscenario-core_dispatch_with_results_50_listeners

scenario:coreapiscenario-core_dispatch_with_results_listeners

scenario:packagesupdateimporteddependencies-import_many_stdlib_cached

Known flaky benchmarks

scenario:iastaspects-swapcase_aspect

scenario:span-start

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

datadog-prod-us1-4 Bot commented Aug 26, 2026 •

edited by datadog-datadog-prod-us1-2 Bot

Loading