Skip to content

test(dramatiq): enable tests for Python 3.14 - #19879

Draft
wantsui wants to merge 2 commits into
mainfrom
worktree-dramatiq-py314
Draft

test(dramatiq): enable tests for Python 3.14#19879
wantsui wants to merge 2 commits into
mainfrom
worktree-dramatiq-py314

Conversation

@wantsui

@wantsui wantsui commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Bumps the max tested Python version for the dramatiq integration from 3.13 to 3.14 in riotfile.py.
  • Regenerates the corresponding riot lockfile (.riot/requirements/17f991e.txt) and supported_versions.json entry.

Test plan

  • scripts/lint riot
  • Confirmed the new Python 3.14 venv (17f991e) is discovered via scripts/run-tests --list tests/contrib/dramatiq/
  • Ran the non-snapshot dramatiq tests directly against the new venv locally (patch/autopatch/retry tests pass on 3.14)
  • Full contrib::dramatiq suite (including snapshot tests) — to be validated by CI

Bumps the max tested Python version for the dramatiq integration and
regenerates the corresponding riot lockfile.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codeowners resolved as

Resolved from the full PR diff against main using the target branch CODEOWNERS file.
CODEOWNERS team requests not listed below are not required by the current file set.

.riot/requirements/17f991e.txt                                          @DataDog/apm-python
riotfile.py                                                             @DataDog/apm-python
supported_versions.json                                                 @DataDog/apm-core-python @DataDog/apm-idm-python

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 26, 2026

Copy link
Copy Markdown

Dependency direction analysis

⚠️ Existing dependency direction violations

There are 240 dependency direction violations that already exist on the base branch and have not been changed by this PR.

Show existing violations (showing 5 of 240 highest severity)
ddtrace.internal.tracemethods -×-> ddtrace.trace  (internal-core -> product:tracing, score=135)
ddtrace.llmobs._integrations.litellm -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)
ddtrace.appsec._contrib.django -×-> ddtrace.trace  (product:appsec -> product:tracing, score=133)
ddtrace.appsec._listeners -×-> ddtrace.trace  (product:appsec -> product:tracing, score=133)
ddtrace.llmobs._telemetry -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)

To see all violations, download the layers-base.json and layers-pr.json artifacts from this CI job and run:

uv run --script scripts/import-analysis/layers.py compare layers-base.json layers-pr.json

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Circular import analysis

⚠️ Existing circular imports

There are 3 circular imports that already exist on the base branch and have not been changed by this PR.

ddtrace.llmobs -> ddtrace.llmobs._evaluators -> ddtrace.llmobs._evaluators.format -> ddtrace.llmobs._experiment -> ddtrace.llmobs
ddtrace.errortracking._handled_exceptions.bytecode_injector -> ddtrace.errortracking._handled_exceptions.callbacks -> ddtrace.errortracking._handled_exceptions.collector -> ddtrace.errortracking._handled_exceptions.bytecode_reporting -> ddtrace.errortracking._handled_exceptions.bytecode_injector
ddtrace.appsec._asm_request_context -> ddtrace.appsec._iast._iast_request_context_base -> ddtrace.appsec._iast._iast_env -> ddtrace.appsec._iast.reporter -> ddtrace.appsec._exploit_prevention.stack_traces -> ddtrace.appsec._asm_request_context

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@wantsui wantsui added changelog/no-changelog A changelog entry is not required for this PR. AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos labels Aug 26, 2026
@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Pipelines  Tests

⚠️ Warnings

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 5 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-py | build linux serverless: [amd64, cp315-cp315, v113741238-d2b8243-manylinux2014_x86_64, 1] — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

Changelog | Validate changelog

View more details · View in GitHub Actions

Release note not found during changelog validation.

DataDog/apm-reliability/dd-trace-py | build linux serverless: [arm64, cp315-cp315, v113741357-d2b8243-manylinux2014_aarch64, 1]

View more details · View in GitLab

View all 5 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: afdad4a | Docs | View more details | Give us feedback!

@pr-commenter

pr-commenter Bot commented Aug 26, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-08-26 22:02:27

Comparing candidate commit afdad4a in PR branch worktree-dramatiq-py314 with baseline commit 489a43c in branch main.

📊 Benchmarking dashboard

Found 0 performance improvements and 5 performance regressions! Performance is the same for 579 metrics, 10 unstable metrics, 1 known flaky benchmarks, 17 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:httppropagationinject-ids_only

  • 🟥 execution_time [+2.343µs; +2.462µs] or [+14.355%; +15.085%]

scenario:iastaspects-upper_aspect

  • 🟥 execution_time [+31.256µs; +37.958µs] or [+13.400%; +16.273%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+112.655µs; +119.879µs] or [+28.484%; +30.310%]

scenario:telemetryaddmetric-1-count-metric-1-times

  • 🟥 execution_time [+507.107ns; +544.870ns] or [+18.871%; +20.277%]

scenario:tracer-small

  • 🟥 execution_time [+32.770µs; +35.360µs] or [+10.252%; +11.062%]

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:coreapiscenario-context_with_data_listeners

  • unstable execution_time [-822.127ns; +662.430ns] or [-7.394%; +5.958%]

scenario:coreapiscenario-core_dispatch_1_listener

  • unstable execution_time [-31.346ns; +35.155ns] or [-5.163%; +5.790%]

scenario:coreapiscenario-core_dispatch_50_listeners

  • unstable execution_time [-1669.998ns; +1627.573ns] or [-9.831%; +9.582%]

scenario:coreapiscenario-core_dispatch_exception_listeners

  • unstable execution_time [-1276.619ns; +1234.615ns] or [-9.773%; +9.451%]

scenario:coreapiscenario-core_dispatch_listeners

  • unstable execution_time [-323.293ns; +324.886ns] or [-8.874%; +8.918%]

scenario:coreapiscenario-core_dispatch_no_args_listeners

  • unstable execution_time [-250.176ns; +254.029ns] or [-8.651%; +8.785%]

scenario:coreapiscenario-core_dispatch_with_results_1_listener

  • unstable execution_time [-63.418ns; +81.167ns] or [-5.310%; +6.797%]

scenario:coreapiscenario-core_dispatch_with_results_50_listeners

  • unstable execution_time [-4036.271ns; +3991.306ns] or [-9.796%; +9.687%]

scenario:coreapiscenario-core_dispatch_with_results_listeners

  • unstable execution_time [-725.417ns; +816.045ns] or [-8.865%; +9.973%]

scenario:packagesupdateimporteddependencies-import_many_stdlib_cached

  • unstable execution_time [-60.678µs; +56.660µs] or [-9.736%; +9.091%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:span-start

  • 🟥 execution_time [+1.128ms; +1.314ms] or [+7.990%; +9.305%]

Known flaky benchmarks without significant changes:

  • scenario:errortrackingflasksqli-baseline
  • scenario:flasksimple-iast-get
  • scenario:iastaspects-casefold_aspect
  • scenario:iastaspects-casefold_noaspect
  • scenario:iastaspects-index_aspect
  • scenario:iastaspects-ljust_noaspect
  • scenario:iastaspects-lower_aspect
  • scenario:iastaspects-replace_aspect
  • scenario:iastaspects-swapcase_aspect
  • scenario:iastaspects-title_noaspect
  • scenario:iastaspects-translate_aspect
  • scenario:iastaspects-translate_noaspect
  • scenario:iastaspects-upper_noaspect
  • scenario:packagespackageforrootmodulemapping-cache_off
  • scenario:packagespackageforrootmodulemapping-cache_on
  • scenario:sethttpmeta-all-enabled
  • scenario:telemetryaddmetric-record-100-metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant