Skip to content

ci: run fork PR #19864 through CI [DO NOT MERGE] - #19882

Draft
dubloom wants to merge 3 commits into
mainfrom
louis-tricot_ddog/mirror-19864
Draft

ci: run fork PR #19864 through CI [DO NOT MERGE]#19882
dubloom wants to merge 3 commits into
mainfrom
louis-tricot_ddog/mirror-19864

Conversation

@dubloom

@dubloom dubloom commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Description

CI-only shadow PR for external contribution #19864 at exact head SHA c078a9c78f115d6605ba5c2f4ea715eab5524801.

DO NOT MERGE. This shadow PR exists only to run CI. The original external contribution remains the PR to merge.

Testing

Runs the full required CI, including GitLab and System Tests, from a repository-owned branch.

Risks

This moves the external contribution into a trusted CI context. The complete four-file contribution diff and the latest merge from trusted main were reviewed before mirroring; there are no contribution changes to workflows, builds, dependencies, credentials, permissions, or artifact uploads.

Additional Notes

After CI passes, verify that the original PR head still matches this SHA, merge the original PR, then close this shadow PR without merging and delete this branch.

Ray 2.58 passes interceptors=None when it constructs an internal async gRPC server without authentication. The tracing wrappers previously tried to convert that value to a tuple and failed before server startup.

Normalize missing, empty, and None interceptor values to the Datadog interceptor tuple while preserving Datadog-first ordering for non-empty user interceptors.
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c078a9c | Docs | View more details | Give us feedback!

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Codeowners resolved as

Resolved from the full PR diff against main using the target branch CODEOWNERS file.
CODEOWNERS team requests not listed below are not required by the current file set.

ddtrace/contrib/internal/grpc/patch.py                                  @DataDog/apm-core-python @DataDog/apm-idm-python
releasenotes/notes/fix-grpc-none-interceptors-4303891f3d24c7d8.yaml     @DataDog/apm-python
tests/contrib/grpc/test_grpc.py                                         @DataDog/apm-idm-python
tests/contrib/grpc_aio/test_grpc_aio.py                                 @DataDog/apm-core-python @DataDog/apm-idm-python

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Dependency direction analysis

⚠️ Existing dependency direction violations

There are 240 dependency direction violations that already exist on the base branch and have not been changed by this PR.

Show existing violations (showing 5 of 240 highest severity)
ddtrace.internal.tracemethods -×-> ddtrace.trace  (internal-core -> product:tracing, score=135)
ddtrace.profiling.collector.pytorch -×-> ddtrace.trace  (product:profiling -> product:tracing, score=133)
ddtrace.llmobs._integrations.langchain -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)
ddtrace.internal.ci_visibility.git_client -×-> ddtrace.trace  (product:ci_visibility -> product:tracing, score=133)
ddtrace.llmobs._integrations.vertexai -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)

To see all violations, download the layers-base.json and layers-pr.json artifacts from this CI job and run:

uv run --script scripts/import-analysis/layers.py compare layers-base.json layers-pr.json

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Circular import analysis

⚠️ Existing circular imports

There are 3 circular imports that already exist on the base branch and have not been changed by this PR.

ddtrace.llmobs -> ddtrace.llmobs._evaluators -> ddtrace.llmobs._evaluators.format -> ddtrace.llmobs._experiment -> ddtrace.llmobs
ddtrace.errortracking._handled_exceptions.bytecode_injector -> ddtrace.errortracking._handled_exceptions.callbacks -> ddtrace.errortracking._handled_exceptions.collector -> ddtrace.errortracking._handled_exceptions.bytecode_reporting -> ddtrace.errortracking._handled_exceptions.bytecode_injector
ddtrace.appsec._asm_request_context -> ddtrace.appsec._iast._iast_request_context_base -> ddtrace.appsec._iast._iast_env -> ddtrace.appsec._iast.reporter -> ddtrace.appsec._exploit_prevention.stack_traces -> ddtrace.appsec._asm_request_context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants