fix(ci): always run cargo-public-api in semver-level.sh#2072
Draft
iunanua wants to merge 1 commit into
Draft
Conversation
cargo-semver-checks misses parameter-type changes on non-generic functions (no function_parameter_type_changed lint), returning minor when the change is actually breaking. Run cargo-public-api unconditionally and take the higher of the two signals via max_level so removed/changed signatures are caught even when cargo-semver-checks already flagged the crate at minor. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2072 +/- ##
==========================================
- Coverage 73.44% 73.42% -0.02%
==========================================
Files 465 465
Lines 77949 77949
==========================================
- Hits 57248 57233 -15
- Misses 20701 20716 +15
🚀 New features to boost your workflow:
|
Contributor
|
🎯 Code Coverage (details) 🔗 Commit SHA: 1c632e1 | Docs | Datadog PR Page | Give us feedback! |
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Always run
cargo-public-apiinsemver-level.shMotivation
cargo-semver-checksmisses parameter-type changes on non-generic functions (no function_parameter_type_changed lint), returning minor when the change is actually breaking. Runcargo-public-apiunconditionally and take the higher of the two signals via max_level so removed/changed signatures are caught even whencargo-semver-checksalready flagged the crate at minor.