fix(ffe): honor shared fixture result metadata#2109
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intoJun 12, 2026
Merged
fix(ffe): honor shared fixture result metadata#2109gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
Conversation
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 59fd76a | Docs | Datadog PR Page | Give us feedback! |
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
leoromanovsky
requested review from
greghuels and
typotter
and removed request for
a team
typotter
approved these changes
Jun 12, 2026
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-mergequeue-cf854d
Bot
merged commit c79d783
into
main
97 of 100 checks passed
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
leo.romanovsky/ffe-shared-fixture-results
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The shared FFE fixtures now assert result metadata beyond returned values, including
reasonanderrorCode. libdatadog was only checking fixture values, so it could accept shared fixture bumps while still drifting on public assignment metadata.The latest
ffe-system-test-datamain also corrects temporal allocation fixtures to expectDEFAULTfor active date-window-only allocations. Those allocations return a configured platform/default value, but no targeting rule matched and no non-vacuous split selected the subject.Changes
This updates the
ffe-system-test-datasubmodule throughd9d8020, including the merged temporal reason correction from DataDog/ffe-system-test-data#15.The canonical fixture harness now asserts fixture-provided
reasonanderrorCodefields in addition to values. Invalid or unsupported per-flag config is represented as a distinct evaluation error that maps to caller-default behavior while preserving isolation for valid flags in the same payload.The evaluator now has an explicit
AssignmentReason::Defaultfor successful default/platform assignments. Active temporal allocations with no rules and no effective split now reportDEFAULT, and the FFI mapping exposes that asddog_ffe_Reason::Default.Decisions
Top-level configuration parse behavior is unchanged: a malformed full payload still fails configuration creation, while malformed individual flags are isolated and evaluate to caller defaults. Missing flags continue to report
FLAG_NOT_FOUND. OptionalerrorCodefixture assertions remain optional because some existing shared cases omit that field even when the reason isERROR.Validation:
cargo +nightly-2026-02-08 fmt --all -- --checkcargo check -p datadog-ffe -p datadog-ffe-ffi -p datadog-ffe-test-suitecargo nextest run -p datadog-ffe -p datadog-ffe-ffi -p datadog-ffe-test-suite --no-fail-fastcargo test --doc -p datadog-ffe -p datadog-ffe-ffi -p datadog-ffe-test-suitecargo +stable clippy -p datadog-ffe -p datadog-ffe-ffi -p datadog-ffe-test-suite --all-targets --all-features -- -D warningscargo +stable clippy --workspace --all-targets --all-features -- -D warningscargo ffi-testbuilt the FFI artifacts and theffeexample passed; the overall command failed in the unrelatedcrashtrackingexample with signal 5.