chore: clippy fix libdd trace normalization by Eldolfin · Pull Request #2111 · DataDog/libdatadog

Eldolfin · 2026-06-12T15:39:57Z

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

…y fixes

… globally allow manual_string_new

…ral lints with FIXME

datadog-prod-us1-4 · 2026-06-12T15:41:06Z

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 72.22%
• Overall Coverage: 73.06% (+0.01%)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 61d1f45 | Docs | Datadog PR Page | Give us feedback!}

github-actions · 2026-06-12T15:41:33Z

📚 Documentation Check Results

⚠️ 126 documentation warning(s) found

📦 `libdd-trace-normalization` - 126 warning(s)

Updated: 2026-06-12 15:56:54 UTC | Commit: 3b732ff | missing-docs job results

github-actions · 2026-06-12T15:43:06Z

Clippy Allow Annotation Report

Comparing clippy allow annotations between branches:

Base Branch: origin/main
PR Branch: origin/oscarld/clippy-fix-libdd-trace-normalization

Summary by Rule

Rule	Base Branch	PR Branch	Change
unwrap_used	2	2	No change (0%)
Total	2	2	No change (0%)

Annotation Counts by File

File	Base Branch	PR Branch	Change
`libdd-trace-normalization/src/normalize_utils.rs`	1	1	No change (0%)
`libdd-trace-normalization/src/utf8_helpers.rs`	1	1	No change (0%)

Annotation Stats by Crate

Crate	Base Branch	PR Branch	Change
`clippy-annotation-reporter`	5	5	No change (0%)
`datadog-ffe-ffi`	1	1	No change (0%)
`datadog-ipc`	21	21	No change (0%)
`datadog-live-debugger`	4	4	No change (0%)
`datadog-live-debugger-ffi`	10	10	No change (0%)
`datadog-profiling-replayer`	4	4	No change (0%)
`datadog-sidecar`	46	46	No change (0%)
`libdd-common`	13	13	No change (0%)
`libdd-common-ffi`	12	12	No change (0%)
`libdd-data-pipeline`	5	5	No change (0%)
`libdd-ddsketch`	2	2	No change (0%)
`libdd-dogstatsd-client`	1	1	No change (0%)
`libdd-profiling`	13	13	No change (0%)
`libdd-remote-config`	3	3	No change (0%)
`libdd-telemetry`	20	20	No change (0%)
`libdd-tinybytes`	4	4	No change (0%)
`libdd-trace-normalization`	2	2	No change (0%)
`libdd-trace-obfuscation`	3	3	No change (0%)
`libdd-trace-stats`	1	1	No change (0%)
`libdd-trace-utils`	12	12	No change (0%)
Total	182	182	No change (0%)

About This Report

This report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality.

github-actions · 2026-06-12T15:43:34Z

🔒 Cargo Deny Results

⚠️ 1 issue(s) found, showing only errors (advisories, bans, sources)

📦 `libdd-trace-normalization` - 1 error(s)

Show output

error[unsound]: Rand is unsound with a custom logger using `rand::rng()`
   ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:51:1
   │
51 │ rand 0.8.5 registry+https://github.com/rust-lang/crates.io-index
   │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ unsound advisory detected
   │
   ├ ID: RUSTSEC-2026-0097
   ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0097
   ├ It has been reported (by @lopopolo) that the `rand` library is [unsound](https://rust-lang.github.io/unsafe-code-guidelines/glossary.html#soundness-of-code--of-a-library) (i.e. that safe code using the public API can cause Undefined Behaviour) when all the following conditions are met:
     
     - The `log` and `thread_rng` features are enabled
     - A [custom logger](https://docs.rs/log/latest/log/#implementing-a-logger) is defined
     - The custom logger accesses `rand::rng()` (previously `rand::thread_rng()`) and calls any `TryRng` (previously `RngCore`) methods on `ThreadRng`
     - The `ThreadRng` (attempts to) reseed while called from the custom logger (this happens every 64 kB of generated data)
     - Trace-level logging is enabled or warn-level logging is enabled and the random source (the `getrandom` crate) is unable to provide a new seed
     
     `TryRng` (previously `RngCore`) methods for `ThreadRng` use `unsafe` code to cast `*mut BlockRng<ReseedingCore>` to `&mut BlockRng<ReseedingCore>`. When all the above conditions are met this results in an aliased mutable reference, violating the Stacked Borrows rules. Miri is able to detect this violation in sample code. Since construction of [aliased mutable references is Undefined Behaviour](https://doc.rust-lang.org/stable/nomicon/references.html), the behaviour of optimized builds is hard to predict.
   ├ Announcement: https://github.com/rust-random/rand/pull/1763
   ├ Solution: Upgrade to >=0.10.1 OR <0.10.0, >=0.9.3 OR <0.9.0, >=0.8.6 (try `cargo update -p rand`)
   ├ rand v0.8.5
     └── (dev) libdd-trace-normalization v2.0.0

advisories FAILED, bans ok, sources ok

Updated: 2026-06-12 15:58:54 UTC | Commit: 3b732ff | dependency-check job results

…local suppression

…e toolchain

dd-octo-sts · 2026-06-12T16:23:18Z

Artifact Size Benchmark Report

aarch64-alpine-linux-musl

Artifact	Baseline	Commit	Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so	7.70 MB	7.70 MB	0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a	83.68 MB	83.68 MB	0% (0 B) 👌

aarch64-unknown-linux-gnu

Artifact	Baseline	Commit	Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a	94.79 MB	94.79 MB	0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so	10.34 MB	10.34 MB	0% (0 B) 👌

libdatadog-x64-windows

Artifact	Baseline	Commit	Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll	24.83 MB	24.83 MB	0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib	87.33 KB	87.33 KB	0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb	180.85 MB	180.86 MB	+0% (+8.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib	925.13 MB	925.18 MB	+0% (+51.34 KB) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll	8.09 MB	8.09 MB	0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib	87.33 KB	87.33 KB	0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb	23.94 MB	23.94 MB	0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib	47.78 MB	47.78 MB	0% (0 B) 👌

libdatadog-x86-windows

Artifact	Baseline	Commit	Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll	21.52 MB	21.52 MB	0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib	88.71 KB	88.71 KB	0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb	184.87 MB	184.87 MB	-0% (-8.00 KB) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib	918.08 MB	918.13 MB	+0% (+51.86 KB) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll	6.24 MB	6.24 MB	0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib	88.71 KB	88.71 KB	0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb	25.66 MB	25.66 MB	0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib	45.41 MB	45.41 MB	0% (0 B) 👌

x86_64-alpine-linux-musl

Artifact	Baseline	Commit	Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a	74.59 MB	74.59 MB	0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so	8.58 MB	8.58 MB	0% (0 B) 👌

x86_64-unknown-linux-gnu

Artifact	Baseline	Commit	Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a	90.02 MB	90.02 MB	0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so	10.44 MB	10.44 MB	0% (0 B) 👌

Eldolfin added 3 commits June 12, 2026 17:18

chore(libdd-trace-normalization): enable workspace lints + auto clipp…

bcadd5a

…y fixes

chore(libdd-trace-normalization): fix clippy style/doc/cast warnings;…

5223011

… globally allow manual_string_new

chore(libdd-trace-normalization): allow intentional casts and structu…

2e16409

…ral lints with FIXME

Eldolfin changed the title ~~Oscarld/clippy fix libdd trace normalization~~ chore: clippy fix libdd trace normalization Jun 12, 2026

Eldolfin added 2 commits June 12, 2026 17:50

chore: globally allow cast_possible_truncation; remove now-redundant …

a3735bc

…local suppression

chore(libdd-trace-normalization): fix clippy::implicit_clone on stabl…

61d1f45

…e toolchain

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: clippy fix libdd trace normalization#2111

chore: clippy fix libdd trace normalization#2111
Eldolfin wants to merge 5 commits into
mainfrom
oscarld/clippy-fix-libdd-trace-normalization

Eldolfin commented Jun 12, 2026

Uh oh!

datadog-prod-us1-4 Bot commented Jun 12, 2026 •

edited by datadog-datadog-prod-us1-2 Bot

Loading

Uh oh!

github-actions Bot commented Jun 12, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 12, 2026

Uh oh!

github-actions Bot commented Jun 12, 2026 •

edited

Loading

Uh oh!

dd-octo-sts Bot commented Jun 12, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Eldolfin commented Jun 12, 2026

What does this PR do?

Motivation

Additional Notes

How to test the change?

Uh oh!

datadog-prod-us1-4 Bot commented Jun 12, 2026 • edited by datadog-datadog-prod-us1-2 Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📚 Documentation Check Results

📦 libdd-trace-normalization - 126 warning(s)

Uh oh!

github-actions Bot commented Jun 12, 2026

Clippy Allow Annotation Report

Summary by Rule

Annotation Counts by File

Annotation Stats by Crate

About This Report

Uh oh!

github-actions Bot commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔒 Cargo Deny Results

📦 libdd-trace-normalization - 1 error(s)

Uh oh!

dd-octo-sts Bot commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Artifact Size Benchmark Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

datadog-prod-us1-4 Bot commented Jun 12, 2026 •

edited by datadog-datadog-prod-us1-2 Bot

Loading

github-actions Bot commented Jun 12, 2026 •

edited

Loading

📦 `libdd-trace-normalization` - 126 warning(s)

github-actions Bot commented Jun 12, 2026 •

edited

Loading

📦 `libdd-trace-normalization` - 1 error(s)

dd-octo-sts Bot commented Jun 12, 2026 •

edited

Loading