ECI-1662 Log every backfill invocation to OCI logging - #160
Draft
erics-ddog wants to merge 1 commit into
Draft
Conversation
hubmanager's invoke is detached/fire-and-forget, so this is the only observable signal that a backfill replay actually started for a given bucket. Uses the plain log package (stdout/stderr -> OCI Logging), not the Datadog client, since backfill mode assumes Datadog may be down.
erics-ddog
marked this pull request as ready for review
July 30, 2026 18:03
erics-ddog
requested review from
EamonBrady1 and
johannzhang8
and removed request for
johannzhang8
July 30, 2026 18:03
EamonBrady1
approved these changes
Jul 30, 2026
erics-ddog
marked this pull request as draft
July 30, 2026 18:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a single log line at the top of
DatadogClient.Backfill(shared by the events/logs/metrics forwarders) recording that a backfill replay was invoked, including the resolved backfill bucket name.Why
hubmanager's backfill trigger invoke is detached/fire-and-forget (
FnInvokeTypeDetached) — there's no synchronous response for the caller to observe. Without this, there's no way to confirm from the OCI side that a given invoke actually started draining a bucket. Uses the plainlogpackage (stdout/stderr, captured by OCI Logging), not the Datadog client, since backfill mode is specifically for when Datadog may be unreachable.Testing
go build ./...andgo test ./...pass fordatadog-functions/lib/client. Not yet validated against a live OCI Logging search — will confirm the log line surfaces there before merging.