ECI-2103 ECI-2110 Enact a timeout for oci operations, make optimizations when looking at other identity domains, and resolve deletion of regional stacks at the beginning of execution - #180
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 8 commits intoSep 2, 2026
Conversation
…ompts, fix bug with tag status
Co-authored-by: Cursor <cursoragent@cursor.com>
johannzhang8
changed the title
johannzhang8
marked this pull request as ready for review
August 28, 2026 20:36
johannzhang8
changed the title
johannzhang8
changed the title
…d-dynamic-groups ECI-2112 fix orphaned identity dynamic group cleanup, fix vault deletion call, add better timeouts
griffin-michalak
approved these changes
Sep 2, 2026
…k-dependencies ECI-2109 ECI-2110 look for extra security lists in vcn for deletion, auto answer oci prompts
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
johannzhang8/eci-optimize-script-prevent-hangs
branch
September 2, 2026 16:25
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Add a three-minute timeout to OCI CLI commands so cleanup cannot hang indefinitely.
Filter Identity Domain queries server-side to retrieve only relevant Datadog users, groups, dynamic groups, and policies.
Log progress while searching Identity Domains.
Skip subscribed regions where the caller receives authorization errors.
Collect regional stack deletion approvals before parallel cleanup begins.
Delete an explicitly supplied parent stack without requiring ownership tags or an additional prompt.
Improve deletion prompts by including resource OCIDs and correct tag-namespace wait-state handling.
Why:
Cleanup could become slow or hang while searching large or inaccessible Identity Domains. Interactive regional-stack prompts could also occur from worker threads after cleanup started, which caused script hangs.
These changes make discovery bounded, reduce unnecessary API pagination, tolerate inaccessible regions, and present destructive confirmations before concurrent cleanup begins.
Testing:
Unit tests, and runs on ddevint1