ECI-2109 ECI-2110 look for extra security lists in vcn for deletion, auto answer oci prompts - #182
Merged
johannzhang8 merged 5 commits intoSep 2, 2026
Conversation
johannzhang8
changed the title
…ompts, fix bug with tag status
Co-authored-by: Cursor <cursoragent@cursor.com>
johannzhang8
force-pushed
the
johannzhang8/eci-discover-network-dependencies
branch
from
August 27, 2026 21:09
388ff6d to
ef5b82e
Compare
johannzhang8
marked this pull request as ready for review
August 28, 2026 20:57
johannzhang8
changed the title
johannzhang8
changed the title
| ], | ||
| ) | ||
| ) | ||
| listed_security_lists = self._list_region( |
Contributor
There was a problem hiding this comment.
Meta-review comment: This is a humongous function, maybe each resource type should have a dedicated cleanup function (or class, if that level of structure is needed), so that the bounds of changes are more clear?
Contributor
Author
There was a problem hiding this comment.
Yeah I was thinking this too, made a ticket for splitting this function into per resource type: https://datadoghq.atlassian.net/browse/ECI-2114
cale-at-ddog
approved these changes
Aug 31, 2026
cale-at-ddog
left a comment
cale-at-ddog
left a comment
Contributor
There was a problem hiding this comment.
These specific changes look good. I'm concerned about the larger structure.
…d-dynamic-groups ECI-2112 fix orphaned identity dynamic group cleanup, fix vault deletion call, add better timeouts
johannzhang8
merged commit Sep 2, 2026
d3ec2a4
into
johannzhang8/eci-optimize-script-prevent-hangs
16 checks passed
johannzhang8
deleted the
johannzhang8/eci-discover-network-dependencies
branch
September 2, 2026 16:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Identify non-default security lists as cleanup candidates while preserving the VCN’s default security list. Prompt these for deletion.
Use forced deletion for security lists and verify Identity Domain deletions remain non-interactive.
Why:
Current list operations can miss network resources attached to the Datadog VCN from another compartment. These dependencies can prevent VCN deletion and leave cleanup incomplete.
Searching by VCN association finds those resources regardless, while preserving the default security list and enforcing dependency-aware deletion keeps cleanup safe.
Testing:
Unit testing