ECI-2112 fix orphaned identity dynamic group cleanup, fix vault deletion call, add better timeouts - #183
Merged
johannzhang8 merged 3 commits intoAug 31, 2026
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
johannzhang8
force-pushed
the
johannzhang8/eci-discover-network-dependencies
branch
from
August 27, 2026 21:09
388ff6d to
ef5b82e
Compare
johannzhang8
force-pushed
the
johannzhang8/eci-cleanup-orphaned-dynamic-groups
branch
from
August 27, 2026 21:09
b357c59 to
1ab3873
Compare
johannzhang8
changed the title
johannzhang8
marked this pull request as ready for review
August 31, 2026 13:31
yuhuyoyo
approved these changes
Aug 31, 2026
johannzhang8
merged commit Aug 31, 2026
1314f39
into
johannzhang8/eci-discover-network-dependencies
16 checks passed
johannzhang8
deleted the
johannzhang8/eci-cleanup-orphaned-dynamic-groups
branch
August 31, 2026 17:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Detect and prompt for deletion orphaned Datadog dynamic groups when their associated IAM policy is already absent.
Delete dynamic groups before their IAM policy and preserve the policy if group cleanup is incomplete.
Continue IAM cleanup despite unrelated regional failures.
Remove Resource Manager stack records even when their Terraform destroy job fails.
Fix vault deletion by using the vault OCID without an incorrect management endpoint.
Treat already-absent functions and VNIC attachments as successfully cleaned up.
Use three-minute read timeouts and extended ten-minute deletion timeouts.
Why:
Partially deleted installations can leave dynamic groups behind after their validating policy disappears.
Terraform destroy job can just fail a lot, and since the script delete the resources manually anyways, it does not matter if the destroy job succeeds for fails.
Testing:
Chaos testing on ddevint1
Unit testing