Skip to content

pup: enable OAuth for ASM WAF commands #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
srosenthal-dd wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −10
Draft

pup: enable OAuth for ASM WAF commands #757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/auth/types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ pub fn read_only_scopes() -> Vec<&'static str> {
"apm_remote_configuration_read",
"apm_service_catalog_read",
"apm_service_ingest_read",
"appsec_protect_read",
"apps_run",
"audit_logs_read",
"aws_configuration_read",
Expand Down Expand Up @@ -119,6 +120,9 @@ pub fn default_scopes() -> Vec<&'static str> {
"apm_service_ingest_read",
"apm_service_ingest_write",
"apm_service_renaming_write",
// AppSec
"appsec_protect_read",
"appsec_protect_write",
// App Builder
"apps_run",
"apps_write",
Expand Down
20 changes: 10 additions & 10 deletions src/commands/security.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,7 @@ pub async fn suppressions_validate(cfg: &Config, file: &str) -> Result<()> {
// ---- ASM WAF Custom Rules ----

pub async fn asm_custom_rules_list(cfg: &Config) -> Result<()> {
let api = crate::make_api_no_auth!(ApplicationSecurityAPI, cfg);
let api = crate::make_api!(ApplicationSecurityAPI, cfg);
let resp = api
.list_application_security_waf_custom_rules()
.await
Expand All @@ -597,7 +597,7 @@ pub async fn asm_custom_rules_list(cfg: &Config) -> Result<()> {
}

pub async fn asm_custom_rules_get(cfg: &Config, custom_rule_id: &str) -> Result<()> {
let api = crate::make_api_no_auth!(ApplicationSecurityAPI, cfg);
let api = crate::make_api!(ApplicationSecurityAPI, cfg);
let resp = api
.get_application_security_waf_custom_rule(custom_rule_id.to_string())
.await
Expand All @@ -607,7 +607,7 @@ pub async fn asm_custom_rules_get(cfg: &Config, custom_rule_id: &str) -> Result<

pub async fn asm_custom_rules_create(cfg: &Config, file: &str) -> Result<()> {
let body: ApplicationSecurityWafCustomRuleCreateRequest = util::read_json_file(file)?;
let api = crate::make_api_no_auth!(ApplicationSecurityAPI, cfg);
let api = crate::make_api!(ApplicationSecurityAPI, cfg);
let resp = api
.create_application_security_waf_custom_rule(body)
.await
Expand All @@ -617,7 +617,7 @@ pub async fn asm_custom_rules_create(cfg: &Config, file: &str) -> Result<()> {

pub async fn asm_custom_rules_update(cfg: &Config, custom_rule_id: &str, file: &str) -> Result<()> {
let body: ApplicationSecurityWafCustomRuleUpdateRequest = util::read_json_file(file)?;
let api = crate::make_api_no_auth!(ApplicationSecurityAPI, cfg);
let api = crate::make_api!(ApplicationSecurityAPI, cfg);
let resp = api
.update_application_security_waf_custom_rule(custom_rule_id.to_string(), body)
.await
Expand All @@ -626,7 +626,7 @@ pub async fn asm_custom_rules_update(cfg: &Config, custom_rule_id: &str, file: &
}

pub async fn asm_custom_rules_delete(cfg: &Config, custom_rule_id: &str) -> Result<()> {
let api = crate::make_api_no_auth!(ApplicationSecurityAPI, cfg);
let api = crate::make_api!(ApplicationSecurityAPI, cfg);
api.delete_application_security_waf_custom_rule(custom_rule_id.to_string())
.await
.map_err(|e| anyhow::anyhow!("failed to delete ASM WAF custom rule: {e:?}"))?;
Expand All @@ -637,7 +637,7 @@ pub async fn asm_custom_rules_delete(cfg: &Config, custom_rule_id: &str) -> Resu
// ---- ASM WAF Exclusion Filters ----

pub async fn asm_exclusions_list(cfg: &Config) -> Result<()> {
let api = crate::make_api_no_auth!(ApplicationSecurityAPI, cfg);
let api = crate::make_api!(ApplicationSecurityAPI, cfg);
let resp = api
.list_application_security_waf_exclusion_filters()
.await
Expand All @@ -646,7 +646,7 @@ pub async fn asm_exclusions_list(cfg: &Config) -> Result<()> {
}

pub async fn asm_exclusions_get(cfg: &Config, exclusion_filter_id: &str) -> Result<()> {
let api = crate::make_api_no_auth!(ApplicationSecurityAPI, cfg);
let api = crate::make_api!(ApplicationSecurityAPI, cfg);
let resp = api
.get_application_security_waf_exclusion_filter(exclusion_filter_id.to_string())
.await
Expand All @@ -656,7 +656,7 @@ pub async fn asm_exclusions_get(cfg: &Config, exclusion_filter_id: &str) -> Resu

pub async fn asm_exclusions_create(cfg: &Config, file: &str) -> Result<()> {
let body: ApplicationSecurityWafExclusionFilterCreateRequest = util::read_json_file(file)?;
let api = crate::make_api_no_auth!(ApplicationSecurityAPI, cfg);
let api = crate::make_api!(ApplicationSecurityAPI, cfg);
let resp = api
.create_application_security_waf_exclusion_filter(body)
.await
Expand All @@ -670,7 +670,7 @@ pub async fn asm_exclusions_update(
file: &str,
) -> Result<()> {
let body: ApplicationSecurityWafExclusionFilterUpdateRequest = util::read_json_file(file)?;
let api = crate::make_api_no_auth!(ApplicationSecurityAPI, cfg);
let api = crate::make_api!(ApplicationSecurityAPI, cfg);
let resp = api
.update_application_security_waf_exclusion_filter(exclusion_filter_id.to_string(), body)
.await
Expand All @@ -679,7 +679,7 @@ pub async fn asm_exclusions_update(
}

pub async fn asm_exclusions_delete(cfg: &Config, exclusion_filter_id: &str) -> Result<()> {
let api = crate::make_api_no_auth!(ApplicationSecurityAPI, cfg);
let api = crate::make_api!(ApplicationSecurityAPI, cfg);
api.delete_application_security_waf_exclusion_filter(exclusion_filter_id.to_string())
.await
.map_err(|e| anyhow::anyhow!("failed to delete ASM WAF exclusion filter: {e:?}"))?;
Expand Down