Camelize strategy name in shared examples#725
Open
leoarnold wants to merge 1 commit intoDatabaseCleaner:mainfrom
Open
Camelize strategy name in shared examples#725leoarnold wants to merge 1 commit intoDatabaseCleaner:mainfrom
leoarnold wants to merge 1 commit intoDatabaseCleaner:mainfrom
Conversation
leoarnold
force-pushed
the
leoarnold/681/spec
branch
2 times, most recently
from
853a192 to
288a9a0
Compare
Following up on DatabaseCleaner#681, we also need to camelize strategy names in the RSpec shared examples for cleaning strategies. For developer convenience, the methods for string manipulation were moved from the Cleaner class to a dedicated StringHelper module.
leoarnold
force-pushed
the
leoarnold/681/spec
branch
from
288a9a0 to
685c779
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #681, we also need to camelize strategy names in the RSpec shared examples for cleaning strategies.
For developer convenience, the methods for string manipulation were moved from the Cleaner class to a dedicated StringHelper module.